You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@devlake.apache.org by "daniel-hutao (via GitHub)" <gi...@apache.org> on 2023/03/28 09:10:10 UTC
[GitHub] [incubator-devlake-helm-chart] daniel-hutao opened a new pull request, #102: feat: add some args to mysql container
daniel-hutao opened a new pull request, #102:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/102
$ kg pod
```sh
NAME READY STATUS RESTARTS AGE
devlake-grafana-66fb6f4b5c-vll9t 1/1 Running 0 91s
devlake-lake-0 1/1 Running 0 9s
devlake-mysql-0 1/1 Running 0 91s
devlake-ui-68c89ccbff-ghft9 1/1 Running 0 91s
```
I've test this change locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-helm-chart] klesh commented on pull request #102: feat: add some args to mysql container
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on PR #102:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/102#issuecomment-1488170649
Here is what I think we should do:
1. create a new tag on the `apache/incubator-devlake`
2. create the same tag in this repo accordingly
Does it make sense to you @daniel-hutao ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-helm-chart] daniel-hutao commented on pull request #102: feat: add some args to mysql container
Posted by "daniel-hutao (via GitHub)" <gi...@apache.org>.
daniel-hutao commented on PR #102:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/102#issuecomment-1487890126
> Seems like we also need to increase chart version?
But the chart version is set to be same as app version in DevLake. I don't know how to update it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-helm-chart] matrixji commented on pull request #102: feat: add some args to mysql container
Posted by "matrixji (via GitHub)" <gi...@apache.org>.
matrixji commented on PR #102:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/102#issuecomment-1493603225
lgtm for the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-helm-chart] matrixji commented on pull request #102: feat: add some args to mysql container
Posted by "matrixji (via GitHub)" <gi...@apache.org>.
matrixji commented on PR #102:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/102#issuecomment-1493656430
> > Seems like we also need to increase chart version?
>
> But the chart version is set to be same as app version in DevLake. I don't know how to update it.
I have pushed new tag with `v0.16.0-beta12` for devlake, we could use that version tag in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-helm-chart] abeizn merged pull request #102: feat: add some args to mysql container
Posted by "abeizn (via GitHub)" <gi...@apache.org>.
abeizn merged PR #102:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org