[GitHub] [skywalking-rover] wu-sheng commented on a diff in pull request #15: Add the Agent Sensor scanner

[GitBox <gi...@apache.org>]

wu-sheng commented on code in PR #15:
URL: https://github.com/apache/skywalking-rover/pull/15#discussion_r851936321


##########
configs/rover_configs.yaml:
##########
@@ -37,30 +37,33 @@ core:
 process_discovery:
   # The period of report or keep alive process(second)
   heartbeat_period: ${ROVER_PROCESS_DISCOVERY_HEARTBEAT_PERIOD:20s}
-  # Detect processes in VM mode
-  vm:
-    # Is active the VM mode to detect processes
-    active: ${ROVER_PROCESS_DISCOVERY_VM_ACTIVE:false}
+  # Scan process from linux
+  scanner:
     # The period to detect the process
-    period: ${ROVER_PROCESS_DISCOVERY_VM_PERIOD:3s}
-    finders:
+    period: ${ROVER_PROCESS_DISCOVERY_SCAN_PERIOD:3s}
+    # The process detect mode of scanner, support "REGEX", "AGENT_SENSOR"

Review Comment:
   ```suggestion
       # The process detection modes of the scanner. Support "REGEX", "AGENT_SENSOR"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org