You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/21 05:36:39 UTC
[GitHub] [doris] xiaokang opened a new pull request, #15231: [improvement](topn)add per scanner limit check for new scanner
xiaokang opened a new pull request, #15231:
URL: https://github.com/apache/doris/pull/15231
# Proposed changes
Optimize for key topn query like `SELECT * FROM store_sales ORDER BY ss_sold_date_sk, ss_sold_time_sk LIMIT 100` (ss_sold_date_sk, ss_sold_time_sk is prefix of table sort key).
Check per scanner limit and set eof true to reduce the data need to be read.
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15231: [improvement](topn)add per scanner limit check for new scanner
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15231:
URL: https://github.com/apache/doris/pull/15231#issuecomment-1362915993
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15231: [improvement](topn)add per scanner limit check for new scanner
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15231:
URL: https://github.com/apache/doris/pull/15231#issuecomment-1362916091
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] cambyzju commented on a diff in pull request #15231: [improvement](topn)add per scanner limit check for new scanner
Posted by GitBox <gi...@apache.org>.
cambyzju commented on code in PR #15231:
URL: https://github.com/apache/doris/pull/15231#discussion_r1054034311
##########
be/src/vec/exec/scan/vscanner.cpp:
##########
@@ -62,10 +62,18 @@ Status VScanner::get_block(RuntimeState* state, Block* block, bool* eof) {
{
SCOPED_TIMER(_parent->_filter_timer);
RETURN_IF_ERROR(_filter_output_block(block));
+ // record rows return (after filter) for _limit check
+ _num_rows_return += block->rows();
}
} while (block->rows() == 0 && !(*eof) && raw_rows_read() < raw_rows_threshold);
}
+ // set eof to true if per scanner limit is reached
+ // currently for query: ORDER BY key LIMIT n
+ if (_limit > 0 && _num_rows_return > _limit) {
Review Comment:
why not '_num_rows_return >= _limit' ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xiaokang commented on a diff in pull request #15231: [improvement](topn)add per scanner limit check for new scanner
Posted by GitBox <gi...@apache.org>.
xiaokang commented on code in PR #15231:
URL: https://github.com/apache/doris/pull/15231#discussion_r1054213845
##########
be/src/vec/exec/scan/vscanner.cpp:
##########
@@ -62,10 +62,18 @@ Status VScanner::get_block(RuntimeState* state, Block* block, bool* eof) {
{
SCOPED_TIMER(_parent->_filter_timer);
RETURN_IF_ERROR(_filter_output_block(block));
+ // record rows return (after filter) for _limit check
+ _num_rows_return += block->rows();
}
} while (block->rows() == 0 && !(*eof) && raw_rows_read() < raw_rows_threshold);
}
+ // set eof to true if per scanner limit is reached
+ // currently for query: ORDER BY key LIMIT n
+ if (_limit > 0 && _num_rows_return > _limit) {
Review Comment:
yes, it's more accurate using >=
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15231: [improvement](topn)add per scanner limit check for new scanner
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15231:
URL: https://github.com/apache/doris/pull/15231#issuecomment-1360881291
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15231: [improvement](topn)add per scanner limit check for new scanner
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15231:
URL: https://github.com/apache/doris/pull/15231#issuecomment-1360960547
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.9 seconds
load time: 642 seconds
storage size: 17123283336 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221221074213_clickbench_pr_66107.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15231: [improvement](topn)add per scanner limit check for new scanner
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15231:
URL: https://github.com/apache/doris/pull/15231#issuecomment-1362307656
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15231: [improvement](topn)add per scanner limit check for new scanner
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15231:
URL: https://github.com/apache/doris/pull/15231#issuecomment-1361159543
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #15231: [improvement](topn)add per scanner limit check for new scanner
Posted by GitBox <gi...@apache.org>.
morningman merged PR #15231:
URL: https://github.com/apache/doris/pull/15231
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org