You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2020/07/29 22:00:00 UTC
[jira] [Commented] (LUCENE-9443) "IndexReader is closed" regression
in highlighter
[ https://issues.apache.org/jira/browse/LUCENE-9443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17167523#comment-17167523 ]
ASF subversion and git services commented on LUCENE-9443:
---------------------------------------------------------
Commit 7d5b61797397fd785c8cc33b2367038d89ace5a9 in lucene-solr's branch refs/heads/master from David Smiley
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=7d5b617 ]
LUCENE-9443: UnifiedHighlighter shouldn't close reader (#1706)
A regression from 8.6. Don't close the underlying IndexReader.
> "IndexReader is closed" regression in highlighter
> -------------------------------------------------
>
> Key: LUCENE-9443
> URL: https://issues.apache.org/jira/browse/LUCENE-9443
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/highlighter
> Affects Versions: 8.6
> Reporter: Chris Beer
> Assignee: David Smiley
> Priority: Major
>
> I'm seeing a regression the UnifiedHighlighter (observed in Solr 8.6, leading to a crashed core), likely caused by LUCENE-9376 ([https://github.com/apache/lucene-solr/commit/8e578b4e51cbab206c31653077ce4a3e3a6879b8#diff-f545e503a21f7331f0706fb89f7c663eR648?)]
> [~dsmiley] adds: [the] call to close indexReaderWithTermVecCache but this is a wrapper IndexReader that is not supposed to be closed. It'll close the underlying real reader if you do which is nasty as that's the live one, which thus brings down the core.
> This is reproducible with Solr 8.6, a trivial configuration ([https://gist.github.com/cbeer/6d3191918b39e3e83e80ac48c00de925),] and an empty index with a request like:
> http://127.0.0.1:8983/solr/blacklight-core/select?q=id:[*+TO+*]&hl=true&hl.fl=full_text_search_en+full_text_search_pt&hl.offsetSource=postings_with_term_vectors&hl.method=unified
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org