[GitHub] [arrow] pitrou commented on a change in pull request #12678: ARROW-15984: [C++] Change RecordBatchReader API to use Result<>

[GitBox <gi...@apache.org>]

pitrou commented on a change in pull request #12678:
URL: https://github.com/apache/arrow/pull/12678#discussion_r832365226



##########
File path: cpp/src/arrow/testing/gtest_util.h
##########
@@ -120,6 +120,11 @@
   ASSIGN_OR_HANDLE_ERROR_IMPL(           \
       ASSERT_OK, ARROW_ASSIGN_OR_RAISE_NAME(_error_or_value, __COUNTER__), lhs, rexpr);
 
+#define ASSERT_OK_NO_THROW_AND_ASSIGN(lhs, rexpr)                                       \
+  ASSIGN_OR_HANDLE_ERROR_IMPL(ASSERT_OK_NO_THROW,                                       \

Review comment:
       Does this have any point? If an exception is thrown, it will simply be caught and reported as an error by GTest.

##########
File path: cpp/src/arrow/record_batch_test.cc
##########
@@ -410,4 +410,32 @@ TEST_F(TestRecordBatchReader, BeginEndForLoop) {
   ASSERT_EQ(i, static_cast<int64_t>(batches_.size()));
 }
 
+ARROW_SUPPRESS_DEPRECATION_WARNING
+TEST_F(TestRecordBatchReader, DeprecatedReadAllToRecordBatches) {

Review comment:
       Should we also test the new (non-deprecated) methods?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org