You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by evanj <gi...@git.apache.org> on 2015/08/25 17:53:58 UTC

[GitHub] thrift pull request: THRIFT-2536: Java: TBinaryProtocol: Use a sin...

GitHub user evanj opened a pull request:

    https://github.com/apache/thrift/pull/595

    THRIFT-2536: Java: TBinaryProtocol: Use a single temp byte[] buffer

    Reduces allocations and GC when TBinaryProtocol is allocated repeatedly.
    
    Originally separate byte[] arrays were allocated for each integer type, and
    a separate array for input and output. However, one buffer of the largest
    size (8 bytes for i64) can be used for all purposes.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/evanj/thrift THRIFT-2536

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/595.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #595
    
----
commit 9a5668e8f2afd1440a94952091bec9f3da64dd3e
Author: Evan Jones <ej...@twitter.com>
Date:   2015-08-25T15:51:07Z

    THRIFT-2536: Java: TBinaryProtocol: Use a single temp byte[] buffer
    
    Reduces allocations and GC when TBinaryProtocol is allocated repeatedly.
    
    Originally separate byte[] arrays were allocated for each integer type, and
    a separate array for input and output. However, one buffer of the largest
    size (8 bytes for i64) can be used for all purposes.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-2536: Java: TBinaryProtocol: Use a sin...

Posted by evanj <gi...@git.apache.org>.
Github user evanj commented on the pull request:

    https://github.com/apache/thrift/pull/595#issuecomment-134644963
  
    Sorry, I copy-and-pasted the wrong ticket number.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-2536: Java: TBinaryProtocol: Use a sin...

Posted by evanj <gi...@git.apache.org>.
Github user evanj closed the pull request at:

    https://github.com/apache/thrift/pull/595


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---