You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@singa.apache.org by GitBox <gi...@apache.org> on 2020/06/30 13:19:47 UTC
[GitHub] [singa] chrishkchris opened a new pull request #754: Fix singa-gpu conda build and update numpy version
chrishkchris opened a new pull request #754:
URL: https://github.com/apache/singa/pull/754
1. When I was building conda package of singa-gpu, I endountered the following error
One available solution is to call `roundf` in CUDA MATH API instead of `std::round `
https://docs.nvidia.com/cuda/cuda-math-api/group__CUDA__MATH__SINGLE.html#group__CUDA__MATH__SINGLE_1ga1c1521079e51b4f54771b16a7f8aeea
With this modification, the round test case can pass:
```
root@e7f452d7c67a:~/dcsysh/singa/test/python# python3 test_api.py
.................................
----------------------------------------------------------------------
Ran 33 tests in 1.409s
OK
```
By the way, in the docker version of singa, it does not need this change, maybe it is the difference of GCC version in the two environments.
2. This PR updates the numpy to 1.18.5
3. Seems the `cudaDeviceReset()` in destructor returns "driver shutting down" code, we don't need the `CUDA_CHECK`.
```
root@e7f452d7c67a:~/dcsysh/singa/test/python# python3 test_api.py
.................................
----------------------------------------------------------------------
Ran 33 tests in 1.383s
OK
WARNING: Logging before InitGoogleLogging() is written to STDERR
F0630 12:40:39.892601 3077 cuda_gpu.cc:49] Check failed: error == cudaSuccess (29 vs. 0) driver shutting down
*** Check failure stack trace: ***
Aborted (core dumped)
```
After changed, it works well
```
root@e7f452d7c67a:~/dcsysh/singa/test/python# python3 test_api.py
.................................
----------------------------------------------------------------------
Ran 33 tests in 1.564s
OK
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] nudles commented on a change in pull request #754: Fix SINGA-gpu conda build and update numpy version
Posted by GitBox <gi...@apache.org>.
nudles commented on a change in pull request #754:
URL: https://github.com/apache/singa/pull/754#discussion_r448066345
##########
File path: tool/conda/singa/meta.yaml
##########
@@ -50,7 +50,7 @@ requirements:
- protobuf 3.10.0 # [osx]
- protobuf 3.9.2 # [linux]
- glog 0.3.5
- - numpy 1.16.5
Review comment:
I think we can use a range like >=1.16,<2.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] chrishkchris commented on a change in pull request #754: Fix SINGA-gpu conda build and update numpy version
Posted by GitBox <gi...@apache.org>.
chrishkchris commented on a change in pull request #754:
URL: https://github.com/apache/singa/pull/754#discussion_r448115522
##########
File path: tool/conda/singa/meta.yaml
##########
@@ -50,7 +50,7 @@ requirements:
- protobuf 3.10.0 # [osx]
- protobuf 3.9.2 # [linux]
- glog 0.3.5
- - numpy 1.16.5
Review comment:
Yes, updated the code. The travis CI build the conda package sucessfully
https://travis-ci.org/github/apache/singa/jobs/703751043#L2518
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] dcslin merged pull request #754: Fix SINGA-gpu conda build and update numpy version
Posted by GitBox <gi...@apache.org>.
dcslin merged pull request #754:
URL: https://github.com/apache/singa/pull/754
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] chrishkchris commented on pull request #754: Fix SINGA-gpu conda build and update numpy version
Posted by GitBox <gi...@apache.org>.
chrishkchris commented on pull request #754:
URL: https://github.com/apache/singa/pull/754#issuecomment-652190994
Yes, updated the code. The travis CI build the conda package sucessfully
https://travis-ci.org/github/apache/singa/jobs/703751043#L2518
Ready for merge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org