You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/04/16 05:17:28 UTC

[GitHub] [netbeans] junichi11 opened a new pull request #2894: [NETBEANS-4443] PHP 8.0 Support: Named Arguments

junichi11 opened a new pull request #2894:
URL: https://github.com/apache/netbeans/pull/2894


   https://issues.apache.org/jira/browse/NETBEANS-4443
   
   - https://wiki.php.net/rfc/named_params
   
   #### Part 3
   Don't highlight(as the keyword color) parameter names when they are keywords
   
   e.g.
   ```php
   test(array: [1, 2], default: "default");
   ```
   
   Notes:
   
   - "default:" is used in a switch statement
   - "true:", "false:", and "null:" can be used with a ternary operator
   - "else:" is used in alternative syntax for a control structure
   
   ![nb-php80-named-arguments--reserved-keywords-coloring](https://user-images.githubusercontent.com/738383/114974431-55c65180-9ebd-11eb-85da-365897d38e1c.jpg)
   
   
   #### Part 4
   
   - Support for code completion for parameter names
   
   ![nb-php80-named-arguments-cc](https://user-images.githubusercontent.com/738383/114974451-6080e680-9ebd-11eb-8d8f-5b4f64d15fc0.jpg)
   
   
   #### Part 5
   
   - Add whitespace when a parameter name is added via Code Completion
   
   When a parameter name is added via Code Completion, the inserted code is
   formatted. However, the whitespace is removed because `functionName(paramName: );` is broken code.
   
   ```php
   
   function test($paramName) {}
   
   // before
   test(paramName:);
   
   // after
   test(paramName: );
   ```
   
   #### Part 6
   
   - Highlighting for Named Arguments
   
   ##### NetBeans
   
   ![nb-php80-named-arguments-coloring-netbeans](https://user-images.githubusercontent.com/738383/114974519-7ee6e200-9ebd-11eb-9c41-624def168b1c.jpg)
   
   ##### FlatLafDark
   
   ![nb-php80-named-arguments-coloring-dark](https://user-images.githubusercontent.com/738383/114974531-84442c80-9ebd-11eb-8fc7-d70469f69633.jpg)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] junichi11 commented on pull request #2894: [NETBEANS-4443] PHP 8.0 Support: Named Arguments

Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #2894:
URL: https://github.com/apache/netbeans/pull/2894#issuecomment-821116505


   @tmysik Thanks a lot for your review and your time!
   
   @geertjanw, @neilcsmith-net 
   
   I follow the release managers. If it's OK for you, please feel free to merge it :) Otherwise, let's merge it in 12.5.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] junichi11 commented on pull request #2894: [NETBEANS-4443] PHP 8.0 Support: Named Arguments

Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #2894:
URL: https://github.com/apache/netbeans/pull/2894#issuecomment-821090515


   @geertjanw I see. Thank you. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] geertjanw commented on pull request #2894: [NETBEANS-4443] PHP 8.0 Support: Named Arguments

Posted by GitBox <gi...@apache.org>.
geertjanw commented on pull request #2894:
URL: https://github.com/apache/netbeans/pull/2894#issuecomment-821109154


   Sure, that would be ideal.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] geertjanw commented on pull request #2894: [NETBEANS-4443] PHP 8.0 Support: Named Arguments

Posted by GitBox <gi...@apache.org>.
geertjanw commented on pull request #2894:
URL: https://github.com/apache/netbeans/pull/2894#issuecomment-821086917


   If @tmysik reviews this in time, I think we should try to include this in 12.4, if you agree.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] junichi11 commented on pull request #2894: [NETBEANS-4443] PHP 8.0 Support: Named Arguments

Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #2894:
URL: https://github.com/apache/netbeans/pull/2894#issuecomment-821078034


   @geertjanw We can merge it into the `master` branch after the `delivery` branch is created, right?
   
   @tmysik Let's merge it later because the milestone is changed to 12.5 :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] neilcsmith-net commented on pull request #2894: [NETBEANS-4443] PHP 8.0 Support: Named Arguments

Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2894:
URL: https://github.com/apache/netbeans/pull/2894#issuecomment-821100127


   >  after the delivery branch is created, we can merge into that branch for inclusion in 12.4,
   
   IMO, it might be better to merge before freeze, review and get testing in the first RC than drop it in later?  Can always revert or tidy up by RC2 if necessary.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tmysik commented on pull request #2894: [NETBEANS-4443] PHP 8.0 Support: Named Arguments

Posted by GitBox <gi...@apache.org>.
tmysik commented on pull request #2894:
URL: https://github.com/apache/netbeans/pull/2894#issuecomment-821110993


   @junichi11 @geertjanw @neilcsmith-net 
   
   Guys, approved, see my previous comment. Let me know if we can merge it now or even better, do it, if we can (I maybe won't be available for the rest of the day).
   
   Thanks Junichi for your amazing work.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] junichi11 commented on pull request #2894: [NETBEANS-4443] PHP 8.0 Support: Named Arguments

Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #2894:
URL: https://github.com/apache/netbeans/pull/2894#issuecomment-820917597


   @tmysik 
   Feature freeze is 18:00 CET (Friday 16 April). https://lists.apache.org/thread.html/rb1b2865c1ca6bd962618b79b2e0c97e0d134a03a05fbfe14a2823c20%40%3Cdev.netbeans.apache.org%3E
   
   So, I think this is too late (and sorry for the huge changes), but could you please review it if you have time? If you don't have time, I'll change the milestone to 12.5, then let's merge this later. (Need not hurry :) It's all my fault.) 
   Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] junichi11 commented on pull request #2894: [NETBEANS-4443] PHP 8.0 Support: Named Arguments

Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #2894:
URL: https://github.com/apache/netbeans/pull/2894#issuecomment-821071023


   @geertjanw OK. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] geertjanw commented on pull request #2894: [NETBEANS-4443] PHP 8.0 Support: Named Arguments

Posted by GitBox <gi...@apache.org>.
geertjanw commented on pull request #2894:
URL: https://github.com/apache/netbeans/pull/2894#issuecomment-821068492


   Looks like great changes but indeed let's change milestone to 12.5.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] geertjanw commented on pull request #2894: [NETBEANS-4443] PHP 8.0 Support: Named Arguments

Posted by GitBox <gi...@apache.org>.
geertjanw commented on pull request #2894:
URL: https://github.com/apache/netbeans/pull/2894#issuecomment-821086470


   @junichi11, after the delivery branch is created, we can merge into that branch for inclusion in 12.4, or into master for inclusion in 12.5.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] junichi11 commented on a change in pull request #2894: [NETBEANS-4443] PHP 8.0 Support: Named Arguments

Posted by GitBox <gi...@apache.org>.
junichi11 commented on a change in pull request #2894:
URL: https://github.com/apache/netbeans/pull/2894#discussion_r614566916



##########
File path: php/php.editor/src/org/netbeans/modules/php/editor/completion/PHPCodeCompletion.java
##########
@@ -1424,6 +1434,158 @@ public boolean isAccepted(PhpElement element) {
         }
     }
 
+    private void autoCompleteClassMethodParameterName(

Review comment:
       Based on this method : https://github.com/apache/netbeans/blob/4e3035d755449849d352439fedc5baf9cfd40ca3/php/php.editor/src/org/netbeans/modules/php/editor/completion/PHPCodeCompletion.java#L1289




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] geertjanw merged pull request #2894: [NETBEANS-4443] PHP 8.0 Support: Named Arguments

Posted by GitBox <gi...@apache.org>.
geertjanw merged pull request #2894:
URL: https://github.com/apache/netbeans/pull/2894


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists