You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2016/12/10 22:51:28 UTC
Review Request 54631: Windows: Disambiguated `os::write` by adding
another overload.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54631/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
Bugs: MESOS-6706
https://issues.apache.org/jira/browse/MESOS-6706
Repository: mesos
Description
-------
This commit will partially address MESOS-6706, specifically a bug
causing calls to `os::write` to fail on Windows for all tests in
`files_tests.cpp`.
On Windows, calling `os::write` with a `char *` literal (e.g.,
`os::write("your_file", ...)` will erroneously dispatch to the overload
of `os::write(HANDLE)` instead of `os::write(const string&)`, because
`HANDLE` is a typedef'd `void *`.
In this commit, we simply add an overload for `char *`, which resolves
the ambiguity and causes most tests in `files_tests.cpp` to pass.
Diffs
-----
3rdparty/stout/include/stout/os/write.hpp 24a69d8f60efd3c2888d464d75164c758b3701a2
Diff: https://reviews.apache.org/r/54631/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 54631: Windows: Disambiguated `os::write` by adding
another overload.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54631/#review159387
-----------------------------------------------------------
Ship it!
3rdparty/stout/include/stout/os/write.hpp (lines 86 - 87)
<https://reviews.apache.org/r/54631/#comment230374>
This copy-pasted comment is not needed.
- Joseph Wu
On Dec. 10, 2016, 2:51 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54631/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2016, 2:51 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
>
>
> Bugs: MESOS-6706
> https://issues.apache.org/jira/browse/MESOS-6706
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit will partially address MESOS-6706, specifically a bug
> causing calls to `os::write` to fail on Windows for all tests in
> `files_tests.cpp`.
>
> On Windows, calling `os::write` with a `char *` literal (e.g.,
> `os::write("your_file", ...)` will erroneously dispatch to the overload
> of `os::write(HANDLE)` instead of `os::write(const string&)`, because
> `HANDLE` is a typedef'd `void *`.
>
> In this commit, we simply add an overload for `char *`, which resolves
> the ambiguity and causes most tests in `files_tests.cpp` to pass.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/write.hpp 24a69d8f60efd3c2888d464d75164c758b3701a2
>
> Diff: https://reviews.apache.org/r/54631/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 54631: Windows: Disambiguated `os::write` by adding
another overload.
Posted by Alex Clemmer <cl...@gmail.com>.
> On Dec. 11, 2016, 3:40 a.m., Mesos ReviewBot wrote:
> > Bad patch!
> >
> > Reviews applied: [54631, 54618, 54611, 54493, 54490, 54489, 54519, 54470, 54462, 54453, 54446, 54415, 54395, 52778, 53552, 53551, 53550, 54324, 53706, 52624, 52625, 52972, 52544, 52364]
> >
> > Failed command: ./support/apply-review.sh -n -r 52544
> >
> > Error:
> > 2016-12-11 03:39:54 URL:https://reviews.apache.org/r/52544/diff/raw/ [15399/15399] -> "52544.patch" [1]
> > error: patch failed: 3rdparty/stout/include/stout/os.hpp:47
> > error: 3rdparty/stout/include/stout/os.hpp: patch does not apply
> >
> > Full log: https://builds.apache.org/job/mesos-reviewbot/16407/console
52544 is a stale review that mpark is replacing. This review should be ready to be applied.
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54631/#review158786
-----------------------------------------------------------
On Dec. 10, 2016, 10:51 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54631/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2016, 10:51 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
>
>
> Bugs: MESOS-6706
> https://issues.apache.org/jira/browse/MESOS-6706
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit will partially address MESOS-6706, specifically a bug
> causing calls to `os::write` to fail on Windows for all tests in
> `files_tests.cpp`.
>
> On Windows, calling `os::write` with a `char *` literal (e.g.,
> `os::write("your_file", ...)` will erroneously dispatch to the overload
> of `os::write(HANDLE)` instead of `os::write(const string&)`, because
> `HANDLE` is a typedef'd `void *`.
>
> In this commit, we simply add an overload for `char *`, which resolves
> the ambiguity and causes most tests in `files_tests.cpp` to pass.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/write.hpp 24a69d8f60efd3c2888d464d75164c758b3701a2
>
> Diff: https://reviews.apache.org/r/54631/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 54631: Windows: Disambiguated `os::write` by adding
another overload.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54631/#review158786
-----------------------------------------------------------
Bad patch!
Reviews applied: [54631, 54618, 54611, 54493, 54490, 54489, 54519, 54470, 54462, 54453, 54446, 54415, 54395, 52778, 53552, 53551, 53550, 54324, 53706, 52624, 52625, 52972, 52544, 52364]
Failed command: ./support/apply-review.sh -n -r 52544
Error:
2016-12-11 03:39:54 URL:https://reviews.apache.org/r/52544/diff/raw/ [15399/15399] -> "52544.patch" [1]
error: patch failed: 3rdparty/stout/include/stout/os.hpp:47
error: 3rdparty/stout/include/stout/os.hpp: patch does not apply
Full log: https://builds.apache.org/job/mesos-reviewbot/16407/console
- Mesos ReviewBot
On Dec. 10, 2016, 10:51 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54631/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2016, 10:51 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
>
>
> Bugs: MESOS-6706
> https://issues.apache.org/jira/browse/MESOS-6706
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit will partially address MESOS-6706, specifically a bug
> causing calls to `os::write` to fail on Windows for all tests in
> `files_tests.cpp`.
>
> On Windows, calling `os::write` with a `char *` literal (e.g.,
> `os::write("your_file", ...)` will erroneously dispatch to the overload
> of `os::write(HANDLE)` instead of `os::write(const string&)`, because
> `HANDLE` is a typedef'd `void *`.
>
> In this commit, we simply add an overload for `char *`, which resolves
> the ambiguity and causes most tests in `files_tests.cpp` to pass.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/write.hpp 24a69d8f60efd3c2888d464d75164c758b3701a2
>
> Diff: https://reviews.apache.org/r/54631/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>