You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/08/09 08:09:41 UTC
[GitHub] [shardingsphere] ThanoshanMV commented on a change in pull request #11692: Add Oracle SQL - Update statement
ThanoshanMV commented on a change in pull request #11692:
URL: https://github.com/apache/shardingsphere/pull/11692#discussion_r684991580
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/segment/dml/assignment/AssignmentSegment.java
##########
@@ -36,5 +39,7 @@
private final ColumnSegment column;
+ private List<ColumnSegment> columns = new LinkedList<>();
Review comment:
> What about combining the column and columns?
We can combine columns as a list but since the `AssignmentSegment` is used across the ShardingSphere project, we need to make changes in all `AssignmentSegment` occurrences. For example in `EncryptAssignmentParameterRewriter`:
What shall we do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org