You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Andrew McGeachie (JIRA)" <ji...@apache.org> on 2009/07/23 20:08:14 UTC
[jira] Created: (THRIFT-548) TBinaryProtocol.m allocates memory on
the stack
TBinaryProtocol.m allocates memory on the stack
-----------------------------------------------
Key: THRIFT-548
URL: https://issues.apache.org/jira/browse/THRIFT-548
Project: Thrift
Issue Type: Bug
Components: Library (Cocoa)
Reporter: Andrew McGeachie
Assignee: Andrew McGeachie
[TBinaryProtocol readStringBody:] allocates a temporary buffer on the stack, causing extremely bad things to sometimes happen when reading large amounts of data.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (THRIFT-548) TBinaryProtocol.m allocates memory on
the stack
Posted by "Andrew McGeachie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew McGeachie closed THRIFT-548.
-----------------------------------
> TBinaryProtocol.m allocates memory on the stack
> -----------------------------------------------
>
> Key: THRIFT-548
> URL: https://issues.apache.org/jira/browse/THRIFT-548
> Project: Thrift
> Issue Type: Bug
> Components: Library (Cocoa)
> Reporter: Andrew McGeachie
> Assignee: Andrew McGeachie
> Attachments: thrift-548.patch
>
>
> [TBinaryProtocol readStringBody:] allocates a temporary buffer on the stack, causing extremely bad things to sometimes happen when reading large amounts of data.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-548) TBinaryProtocol.m allocates memory on
the stack
Posted by "Andrew McGeachie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew McGeachie resolved THRIFT-548.
-------------------------------------
Resolution: Fixed
Committed.
> TBinaryProtocol.m allocates memory on the stack
> -----------------------------------------------
>
> Key: THRIFT-548
> URL: https://issues.apache.org/jira/browse/THRIFT-548
> Project: Thrift
> Issue Type: Bug
> Components: Library (Cocoa)
> Reporter: Andrew McGeachie
> Assignee: Andrew McGeachie
> Attachments: thrift-548.patch
>
>
> [TBinaryProtocol readStringBody:] allocates a temporary buffer on the stack, causing extremely bad things to sometimes happen when reading large amounts of data.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-548) TBinaryProtocol.m allocates memory on
the stack
Posted by "Andrew McGeachie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew McGeachie updated THRIFT-548:
------------------------------------
Patch Info: [Patch Available]
> TBinaryProtocol.m allocates memory on the stack
> -----------------------------------------------
>
> Key: THRIFT-548
> URL: https://issues.apache.org/jira/browse/THRIFT-548
> Project: Thrift
> Issue Type: Bug
> Components: Library (Cocoa)
> Reporter: Andrew McGeachie
> Assignee: Andrew McGeachie
> Attachments: thrift-548.patch
>
>
> [TBinaryProtocol readStringBody:] allocates a temporary buffer on the stack, causing extremely bad things to sometimes happen when reading large amounts of data.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-548) TBinaryProtocol.m allocates memory on
the stack
Posted by "Andrew McGeachie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew McGeachie updated THRIFT-548:
------------------------------------
The attached patch fixes this by malloc the memory instead and throwing an expection if the malloc fails.
> TBinaryProtocol.m allocates memory on the stack
> -----------------------------------------------
>
> Key: THRIFT-548
> URL: https://issues.apache.org/jira/browse/THRIFT-548
> Project: Thrift
> Issue Type: Bug
> Components: Library (Cocoa)
> Reporter: Andrew McGeachie
> Assignee: Andrew McGeachie
> Attachments: thrift-548.patch
>
>
> [TBinaryProtocol readStringBody:] allocates a temporary buffer on the stack, causing extremely bad things to sometimes happen when reading large amounts of data.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-548) TBinaryProtocol.m allocates memory on
the stack
Posted by "Andrew McGeachie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew McGeachie updated THRIFT-548:
------------------------------------
Attachment: thrift-548.patch
> TBinaryProtocol.m allocates memory on the stack
> -----------------------------------------------
>
> Key: THRIFT-548
> URL: https://issues.apache.org/jira/browse/THRIFT-548
> Project: Thrift
> Issue Type: Bug
> Components: Library (Cocoa)
> Reporter: Andrew McGeachie
> Assignee: Andrew McGeachie
> Attachments: thrift-548.patch
>
>
> [TBinaryProtocol readStringBody:] allocates a temporary buffer on the stack, causing extremely bad things to sometimes happen when reading large amounts of data.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.