You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2018/01/23 12:01:33 UTC

[GitHub] flink pull request #5338: [FLINK-8476][config][HA] Deprecate HA config const...

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/5338

    [FLINK-8476][config][HA] Deprecate HA config constants

    ## What is the purpose of the change
    
    This PR deprecates multiple HA-related `ConfigConstants`.
    
    ## Brief change log
    
    Deprecated:
    - CC#HA_MODE as it is completely subsumed by HAOptions#HA_MODE
    - CC#HA_JOB_DELAY as it is completely subsumed by HAOptions#HA_JOB_DELAY
    - CC#DEFAULT_HA_MODE as subsumed by HAOptions#HA_MODE
    	- still used by 2 tests (HighAvailabilityModeTest / TestingUtils (scala))
    - CC#DEFAULT_HA_JOB_MANAGER_PORT as it is no longer used
    
    ## Verifying this change
    
    Only modifies annotations / javadocs so it shouldn't affect functionality.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 8476

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5338.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5338
    
----
commit af2d4d7d94b3ed4a54b2310f7feaba0ac3142321
Author: zentol <ch...@...>
Date:   2018-01-23T11:32:06Z

    [FLINK-8476][config][HA] Deprecate HA config constants

----


---

[GitHub] flink pull request #5338: [FLINK-8476][config][HA] Deprecate HA config const...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5338


---

[GitHub] flink issue #5338: [FLINK-8476][config][HA] Deprecate HA config constants

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/5338
  
    Thanks, good change, +1


---

[GitHub] flink issue #5338: [FLINK-8476][config][HA] Deprecate HA config constants

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/5338
  
    merging.


---