[GitHub] [iceberg] kbendick commented on pull request #4873: API: Pass FileIO into Snapshot methods that read metadata

[GitBox <gi...@apache.org>]

kbendick commented on PR #4873:
URL: https://github.com/apache/iceberg/pull/4873#issuecomment-1138172352

   > Looks great! Thanks @kbendick. It's great to have this cleaned up. I've been wanting to do it for a long time now.
   
   Thanks @rdblue. This makes a lot of sense to me as well, as the TableMetadata should be transmissible in a way that doesn’t immediately couple itself to the FileSystem (or choice of FileIO etc).
   
   I know it seems like a large change but it’s really mostly just tests and the FileIO is already properly serialized for Kryo etc where need be. So the change isn’t nearly as large as it seems.
   
   **Question**: Should I update tests and code for earlier Spark versions and Flink versions in this PR or in another? It would make code maintenance simpler to keep other versions in sync (either here or in another PR). But happy to slice the PRs however is deemed best.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org