You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2015/03/23 08:26:24 UTC
Review Request 32388: LENS-412: move missing partition cause to
storage table level
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32388/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-412
https://issues.apache.org/jira/browse/LENS-412
Repository: lens
Description
-------
some moving around in error codes.
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java bfeff4f7443a3e8d0adcf04dc9a5a440e5a3fc24
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java c29d88f1fe32c62947af6ca44179299d446c638c
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 42782297118dbff231cc2a02de8813f58162b705
Diff: https://reviews.apache.org/r/32388/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 32388: LENS-412: move missing partition cause to
storage table level
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On March 23, 2015, 1:28 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java, line 99
> > <https://reviews.apache.org/r/32388/diff/1/?file=902605#file902605line99>
> >
> > We need to have this back. May be the storage cause should get bubbled up.
>
> Rajat Khandelwal wrote:
> We can keep both.
Not adding this back. brief error can have it when it's the most severe of all the errors.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32388/#review77380
-----------------------------------------------------------
On March 24, 2015, 12:42 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32388/
> -----------------------------------------------------------
>
> (Updated March 24, 2015, 12:42 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-412
> https://issues.apache.org/jira/browse/LENS-412
>
>
> Repository: lens
>
>
> Description
> -------
>
> some moving around in error codes.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java bfeff4f7443a3e8d0adcf04dc9a5a440e5a3fc24
> lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java ae9e0136ba521fbcc7fc139bc79dbb1df7c7f6e5
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java c29d88f1fe32c62947af6ca44179299d446c638c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 42782297118dbff231cc2a02de8813f58162b705
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java c9972e23419a00fb5729b854b8feea9b44b125a3
>
> Diff: https://reviews.apache.org/r/32388/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 32388: LENS-412: move missing partition cause to
storage table level
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On March 23, 2015, 1:28 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java, line 118
> > <https://reviews.apache.org/r/32388/diff/1/?file=902607#file902607line118>
> >
> > brief error should be missing partitions
Yes working on that.
> On March 23, 2015, 1:28 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java, line 99
> > <https://reviews.apache.org/r/32388/diff/1/?file=902605#file902605line99>
> >
> > We need to have this back. May be the storage cause should get bubbled up.
We can keep both.
> On March 23, 2015, 1:28 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java, line 869
> > <https://reviews.apache.org/r/32388/diff/1/?file=902607#file902607line869>
> >
> > No_candidate-storage cause is fully gone?
Will put it back. Anyway cheapfact will always give no supported candidate storages.
> On March 23, 2015, 1:28 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java, line 857
> > <https://reviews.apache.org/r/32388/diff/1/?file=902607#file902607line857>
> >
> > brief should be missing partitions
Working on that.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32388/#review77380
-----------------------------------------------------------
On March 23, 2015, 12:56 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32388/
> -----------------------------------------------------------
>
> (Updated March 23, 2015, 12:56 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-412
> https://issues.apache.org/jira/browse/LENS-412
>
>
> Repository: lens
>
>
> Description
> -------
>
> some moving around in error codes.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java bfeff4f7443a3e8d0adcf04dc9a5a440e5a3fc24
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java c29d88f1fe32c62947af6ca44179299d446c638c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 42782297118dbff231cc2a02de8813f58162b705
>
> Diff: https://reviews.apache.org/r/32388/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 32388: LENS-412: move missing partition cause to
storage table level
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32388/#review77380
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
<https://reviews.apache.org/r/32388/#comment125394>
We need to have this back. May be the storage cause should get bubbled up.
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java
<https://reviews.apache.org/r/32388/#comment125384>
brief error should be missing partitions
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java
<https://reviews.apache.org/r/32388/#comment125380>
brief should be missing partitions
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java
<https://reviews.apache.org/r/32388/#comment125378>
No_candidate-storage cause is fully gone?
- Amareshwari Sriramadasu
On March 23, 2015, 7:26 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32388/
> -----------------------------------------------------------
>
> (Updated March 23, 2015, 7:26 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-412
> https://issues.apache.org/jira/browse/LENS-412
>
>
> Repository: lens
>
>
> Description
> -------
>
> some moving around in error codes.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java bfeff4f7443a3e8d0adcf04dc9a5a440e5a3fc24
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java c29d88f1fe32c62947af6ca44179299d446c638c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 42782297118dbff231cc2a02de8813f58162b705
>
> Diff: https://reviews.apache.org/r/32388/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 32388: LENS-412: move missing partition cause to
storage table level
Posted by Himanshu Gahlaut <ga...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32388/#review77537
-----------------------------------------------------------
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java
<https://reviews.apache.org/r/32388/#comment125650>
pruneCauses.getDetails().get("testfact").iterator().next().getStorageCauses().values()
if we break this statement into multiple statements and then put it in a private method which can be reused at multiple places, then will the code become more readable ?
- Himanshu Gahlaut
On March 24, 2015, 7:24 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32388/
> -----------------------------------------------------------
>
> (Updated March 24, 2015, 7:24 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-412
> https://issues.apache.org/jira/browse/LENS-412
>
>
> Repository: lens
>
>
> Description
> -------
>
> some moving around in error codes.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java bfeff4f7443a3e8d0adcf04dc9a5a440e5a3fc24
> lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java ae9e0136ba521fbcc7fc139bc79dbb1df7c7f6e5
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java c29d88f1fe32c62947af6ca44179299d446c638c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 42782297118dbff231cc2a02de8813f58162b705
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java c9972e23419a00fb5729b854b8feea9b44b125a3
>
> Diff: https://reviews.apache.org/r/32388/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.340s]
> [INFO] Lens .............................................. SUCCESS [1.828s]
> [INFO] Lens API .......................................... SUCCESS [5.302s]
> [INFO] Lens API for server and extensions ................ SUCCESS [6.013s]
> [INFO] Lens Cube ......................................... SUCCESS [1:59.809s]
> [INFO] Lens DB storage ................................... SUCCESS [10.082s]
> [INFO] Lens Query Library ................................ SUCCESS [4.889s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:36.279s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [17.846s]
> [INFO] Lens Server ....................................... SUCCESS [4:21.116s]
> [INFO] Lens client ....................................... SUCCESS [20.821s]
> [INFO] Lens CLI .......................................... SUCCESS [2:12.557s]
> [INFO] Lens Examples ..................................... SUCCESS [0.877s]
> [INFO] Lens Distribution ................................. SUCCESS [10.239s]
> [INFO] Lens ML Lib ....................................... SUCCESS [42.718s]
> [INFO] Lens Regression ................................... SUCCESS [0.460s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:14.098s
> [INFO] Finished at: Tue Mar 24 07:22:39 UTC 2015
> [INFO] Final Memory: 109M/1216M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 32388: LENS-412: move missing partition cause to
storage table level
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On March 24, 2015, 2:16 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java, line 74
> > <https://reviews.apache.org/r/32388/diff/3/?file=903845#file903845line74>
> >
> > Why is the order changed?
> >
> > No fact update period should take more precedence than unsupported storage. I think that would be broken.
> >
> > Or this might also be moved to storage causes.
no fact update period is checked before the storage level check. So I think if one fact was skipped because of no suitable update periods, and another was skipped because of storage table level causes, then the latter error is the one that should get priority.
> On March 24, 2015, 2:16 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java, line 540
> > <https://reviews.apache.org/r/32388/diff/3/?file=903847#file903847line540>
> >
> > This is not adding all missing parts. SkipStorageCause.missingPartitions is doing simple set on the ArrayList - would always set only one missing partition.
Depends on `CubeQueryConfUtil.ADD_NON_EXISTING_PARTITIONS`. If true, all missing parts will be added. If not, one missing part of each of the storage tables will be displayed in the final error.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32388/#review77539
-----------------------------------------------------------
On March 24, 2015, 12:54 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32388/
> -----------------------------------------------------------
>
> (Updated March 24, 2015, 12:54 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-412
> https://issues.apache.org/jira/browse/LENS-412
>
>
> Repository: lens
>
>
> Description
> -------
>
> some moving around in error codes.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java bfeff4f7443a3e8d0adcf04dc9a5a440e5a3fc24
> lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java ae9e0136ba521fbcc7fc139bc79dbb1df7c7f6e5
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java c29d88f1fe32c62947af6ca44179299d446c638c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 42782297118dbff231cc2a02de8813f58162b705
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java c9972e23419a00fb5729b854b8feea9b44b125a3
>
> Diff: https://reviews.apache.org/r/32388/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.340s]
> [INFO] Lens .............................................. SUCCESS [1.828s]
> [INFO] Lens API .......................................... SUCCESS [5.302s]
> [INFO] Lens API for server and extensions ................ SUCCESS [6.013s]
> [INFO] Lens Cube ......................................... SUCCESS [1:59.809s]
> [INFO] Lens DB storage ................................... SUCCESS [10.082s]
> [INFO] Lens Query Library ................................ SUCCESS [4.889s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:36.279s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [17.846s]
> [INFO] Lens Server ....................................... SUCCESS [4:21.116s]
> [INFO] Lens client ....................................... SUCCESS [20.821s]
> [INFO] Lens CLI .......................................... SUCCESS [2:12.557s]
> [INFO] Lens Examples ..................................... SUCCESS [0.877s]
> [INFO] Lens Distribution ................................. SUCCESS [10.239s]
> [INFO] Lens ML Lib ....................................... SUCCESS [42.718s]
> [INFO] Lens Regression ................................... SUCCESS [0.460s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:14.098s
> [INFO] Finished at: Tue Mar 24 07:22:39 UTC 2015
> [INFO] Final Memory: 109M/1216M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 32388: LENS-412: move missing partition cause to
storage table level
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32388/#review77539
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
<https://reviews.apache.org/r/32388/#comment125656>
Why is the order changed?
No fact update period should take more precedence than unsupported storage. I think that would be broken.
Or this might also be moved to storage causes.
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java
<https://reviews.apache.org/r/32388/#comment125657>
This is not adding all missing parts. SkipStorageCause.missingPartitions is doing simple set on the ArrayList - would always set only one missing partition.
- Amareshwari Sriramadasu
On March 24, 2015, 7:24 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32388/
> -----------------------------------------------------------
>
> (Updated March 24, 2015, 7:24 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-412
> https://issues.apache.org/jira/browse/LENS-412
>
>
> Repository: lens
>
>
> Description
> -------
>
> some moving around in error codes.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java bfeff4f7443a3e8d0adcf04dc9a5a440e5a3fc24
> lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java ae9e0136ba521fbcc7fc139bc79dbb1df7c7f6e5
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java c29d88f1fe32c62947af6ca44179299d446c638c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 42782297118dbff231cc2a02de8813f58162b705
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java c9972e23419a00fb5729b854b8feea9b44b125a3
>
> Diff: https://reviews.apache.org/r/32388/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.340s]
> [INFO] Lens .............................................. SUCCESS [1.828s]
> [INFO] Lens API .......................................... SUCCESS [5.302s]
> [INFO] Lens API for server and extensions ................ SUCCESS [6.013s]
> [INFO] Lens Cube ......................................... SUCCESS [1:59.809s]
> [INFO] Lens DB storage ................................... SUCCESS [10.082s]
> [INFO] Lens Query Library ................................ SUCCESS [4.889s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:36.279s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [17.846s]
> [INFO] Lens Server ....................................... SUCCESS [4:21.116s]
> [INFO] Lens client ....................................... SUCCESS [20.821s]
> [INFO] Lens CLI .......................................... SUCCESS [2:12.557s]
> [INFO] Lens Examples ..................................... SUCCESS [0.877s]
> [INFO] Lens Distribution ................................. SUCCESS [10.239s]
> [INFO] Lens ML Lib ....................................... SUCCESS [42.718s]
> [INFO] Lens Regression ................................... SUCCESS [0.460s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:14.098s
> [INFO] Finished at: Tue Mar 24 07:22:39 UTC 2015
> [INFO] Final Memory: 109M/1216M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 32388: LENS-412: move missing partition cause to
storage table level
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32388/
-----------------------------------------------------------
(Updated March 25, 2015, 6:48 p.m.)
Review request for lens.
Bugs: LENS-412
https://issues.apache.org/jira/browse/LENS-412
Repository: lens
Description
-------
some moving around in error codes.
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/StorageConstants.java aee9f7b8b0f08df578483ec46de8408541e0bdd0
lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java 6a5b31d6fee007e0b36a97d969ab382a58d88066
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 7eda58a3330147cc4386c999815de619351a388c
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java PRE-CREATION
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java bfeff4f7443a3e8d0adcf04dc9a5a440e5a3fc24
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java c3142cd329e178f3cd4580cb10cf0a23815bf666
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java df5a212c36202f6edbcee01efe9f51e6eaa137d5
lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java ae9e0136ba521fbcc7fc139bc79dbb1df7c7f6e5
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java c29d88f1fe32c62947af6ca44179299d446c638c
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageUtil.java 354c735919ed41742976b1426bbc6322b1a51a41
lens-cube/src/test/java/org/apache/lens/cube/metadata/timeline/TestPartitionTimelines.java 0027e64997fd8a7a367a99c11d3017d334f2e631
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 42782297118dbff231cc2a02de8813f58162b705
Diff: https://reviews.apache.org/r/32388/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.340s]
[INFO] Lens .............................................. SUCCESS [1.828s]
[INFO] Lens API .......................................... SUCCESS [5.302s]
[INFO] Lens API for server and extensions ................ SUCCESS [6.013s]
[INFO] Lens Cube ......................................... SUCCESS [1:59.809s]
[INFO] Lens DB storage ................................... SUCCESS [10.082s]
[INFO] Lens Query Library ................................ SUCCESS [4.889s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:36.279s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [17.846s]
[INFO] Lens Server ....................................... SUCCESS [4:21.116s]
[INFO] Lens client ....................................... SUCCESS [20.821s]
[INFO] Lens CLI .......................................... SUCCESS [2:12.557s]
[INFO] Lens Examples ..................................... SUCCESS [0.877s]
[INFO] Lens Distribution ................................. SUCCESS [10.239s]
[INFO] Lens ML Lib ....................................... SUCCESS [42.718s]
[INFO] Lens Regression ................................... SUCCESS [0.460s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13:14.098s
[INFO] Finished at: Tue Mar 24 07:22:39 UTC 2015
[INFO] Final Memory: 109M/1216M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 32388: LENS-412: move missing partition cause to
storage table level
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32388/
-----------------------------------------------------------
(Updated March 24, 2015, 6:07 p.m.)
Review request for lens.
Bugs: LENS-412
https://issues.apache.org/jira/browse/LENS-412
Repository: lens
Description
-------
some moving around in error codes.
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java bfeff4f7443a3e8d0adcf04dc9a5a440e5a3fc24
lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java ae9e0136ba521fbcc7fc139bc79dbb1df7c7f6e5
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java c29d88f1fe32c62947af6ca44179299d446c638c
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 42782297118dbff231cc2a02de8813f58162b705
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java c9972e23419a00fb5729b854b8feea9b44b125a3
Diff: https://reviews.apache.org/r/32388/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.340s]
[INFO] Lens .............................................. SUCCESS [1.828s]
[INFO] Lens API .......................................... SUCCESS [5.302s]
[INFO] Lens API for server and extensions ................ SUCCESS [6.013s]
[INFO] Lens Cube ......................................... SUCCESS [1:59.809s]
[INFO] Lens DB storage ................................... SUCCESS [10.082s]
[INFO] Lens Query Library ................................ SUCCESS [4.889s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:36.279s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [17.846s]
[INFO] Lens Server ....................................... SUCCESS [4:21.116s]
[INFO] Lens client ....................................... SUCCESS [20.821s]
[INFO] Lens CLI .......................................... SUCCESS [2:12.557s]
[INFO] Lens Examples ..................................... SUCCESS [0.877s]
[INFO] Lens Distribution ................................. SUCCESS [10.239s]
[INFO] Lens ML Lib ....................................... SUCCESS [42.718s]
[INFO] Lens Regression ................................... SUCCESS [0.460s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13:14.098s
[INFO] Finished at: Tue Mar 24 07:22:39 UTC 2015
[INFO] Final Memory: 109M/1216M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 32388: LENS-412: move missing partition cause to
storage table level
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32388/
-----------------------------------------------------------
(Updated March 24, 2015, 12:54 p.m.)
Review request for lens.
Bugs: LENS-412
https://issues.apache.org/jira/browse/LENS-412
Repository: lens
Description
-------
some moving around in error codes.
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java bfeff4f7443a3e8d0adcf04dc9a5a440e5a3fc24
lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java ae9e0136ba521fbcc7fc139bc79dbb1df7c7f6e5
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java c29d88f1fe32c62947af6ca44179299d446c638c
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 42782297118dbff231cc2a02de8813f58162b705
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java c9972e23419a00fb5729b854b8feea9b44b125a3
Diff: https://reviews.apache.org/r/32388/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.340s]
[INFO] Lens .............................................. SUCCESS [1.828s]
[INFO] Lens API .......................................... SUCCESS [5.302s]
[INFO] Lens API for server and extensions ................ SUCCESS [6.013s]
[INFO] Lens Cube ......................................... SUCCESS [1:59.809s]
[INFO] Lens DB storage ................................... SUCCESS [10.082s]
[INFO] Lens Query Library ................................ SUCCESS [4.889s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:36.279s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [17.846s]
[INFO] Lens Server ....................................... SUCCESS [4:21.116s]
[INFO] Lens client ....................................... SUCCESS [20.821s]
[INFO] Lens CLI .......................................... SUCCESS [2:12.557s]
[INFO] Lens Examples ..................................... SUCCESS [0.877s]
[INFO] Lens Distribution ................................. SUCCESS [10.239s]
[INFO] Lens ML Lib ....................................... SUCCESS [42.718s]
[INFO] Lens Regression ................................... SUCCESS [0.460s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13:14.098s
[INFO] Finished at: Tue Mar 24 07:22:39 UTC 2015
[INFO] Final Memory: 109M/1216M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 32388: LENS-412: move missing partition cause to
storage table level
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32388/
-----------------------------------------------------------
(Updated March 24, 2015, 12:46 p.m.)
Review request for lens.
Bugs: LENS-412
https://issues.apache.org/jira/browse/LENS-412
Repository: lens
Description
-------
some moving around in error codes.
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java bfeff4f7443a3e8d0adcf04dc9a5a440e5a3fc24
lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java ae9e0136ba521fbcc7fc139bc79dbb1df7c7f6e5
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java c29d88f1fe32c62947af6ca44179299d446c638c
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 42782297118dbff231cc2a02de8813f58162b705
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java c9972e23419a00fb5729b854b8feea9b44b125a3
Diff: https://reviews.apache.org/r/32388/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 32388: LENS-412: move missing partition cause to
storage table level
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32388/
-----------------------------------------------------------
(Updated March 24, 2015, 12:42 p.m.)
Review request for lens.
Bugs: LENS-412
https://issues.apache.org/jira/browse/LENS-412
Repository: lens
Description
-------
some moving around in error codes.
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java bfeff4f7443a3e8d0adcf04dc9a5a440e5a3fc24
lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java ae9e0136ba521fbcc7fc139bc79dbb1df7c7f6e5
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java c29d88f1fe32c62947af6ca44179299d446c638c
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 42782297118dbff231cc2a02de8813f58162b705
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java c9972e23419a00fb5729b854b8feea9b44b125a3
Diff: https://reviews.apache.org/r/32388/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 32388: LENS-412: move missing partition cause to
storage table level
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On March 23, 2015, 2:53 p.m., Himanshu Gahlaut wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java, line 36
> > <https://reviews.apache.org/r/32388/diff/1/?file=902605#file902605line36>
> >
> > will @Slf4j work in place of @CommonsLog ?
Everywhere we're using commons log. Don't know whether slf4j will work or not.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32388/#review77383
-----------------------------------------------------------
On March 23, 2015, 12:56 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32388/
> -----------------------------------------------------------
>
> (Updated March 23, 2015, 12:56 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-412
> https://issues.apache.org/jira/browse/LENS-412
>
>
> Repository: lens
>
>
> Description
> -------
>
> some moving around in error codes.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java bfeff4f7443a3e8d0adcf04dc9a5a440e5a3fc24
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java c29d88f1fe32c62947af6ca44179299d446c638c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 42782297118dbff231cc2a02de8813f58162b705
>
> Diff: https://reviews.apache.org/r/32388/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 32388: LENS-412: move missing partition cause to
storage table level
Posted by Himanshu Gahlaut <ga...@gmail.com>.
> On March 23, 2015, 9:23 a.m., Himanshu Gahlaut wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java, line 36
> > <https://reviews.apache.org/r/32388/diff/1/?file=902605#file902605line36>
> >
> > will @Slf4j work in place of @CommonsLog ?
>
> Rajat Khandelwal wrote:
> Everywhere we're using commons log. Don't know whether slf4j will work or not.
It should work if below dependencies are present in pom.xml and log4j.properties is present in classpath. I guess I already used it in test cases of lens-cube. Refer annotaion on CubeTestSetup.class.
<dependency>
<groupId>org.projectlombok</groupId>
<artifactId>lombok</artifactId>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-log4j12</artifactId>
</dependency>
<dependency>
<groupId>log4j</groupId>
<artifactId>log4j</artifactId>
</dependency>
Its better to use @Slf4j in new code so that parametrized logging can be utilized and we can slowly move towards using logback instead of log4j for better logging performance and better features.
- Himanshu
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32388/#review77383
-----------------------------------------------------------
On March 23, 2015, 7:26 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32388/
> -----------------------------------------------------------
>
> (Updated March 23, 2015, 7:26 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-412
> https://issues.apache.org/jira/browse/LENS-412
>
>
> Repository: lens
>
>
> Description
> -------
>
> some moving around in error codes.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java bfeff4f7443a3e8d0adcf04dc9a5a440e5a3fc24
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java c29d88f1fe32c62947af6ca44179299d446c638c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 42782297118dbff231cc2a02de8813f58162b705
>
> Diff: https://reviews.apache.org/r/32388/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 32388: LENS-412: move missing partition cause to
storage table level
Posted by Himanshu Gahlaut <ga...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32388/#review77383
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
<https://reviews.apache.org/r/32388/#comment125400>
will @Slf4j work in place of @CommonsLog ?
- Himanshu Gahlaut
On March 23, 2015, 7:26 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32388/
> -----------------------------------------------------------
>
> (Updated March 23, 2015, 7:26 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-412
> https://issues.apache.org/jira/browse/LENS-412
>
>
> Repository: lens
>
>
> Description
> -------
>
> some moving around in error codes.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java bfeff4f7443a3e8d0adcf04dc9a5a440e5a3fc24
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java c29d88f1fe32c62947af6ca44179299d446c638c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 42782297118dbff231cc2a02de8813f58162b705
>
> Diff: https://reviews.apache.org/r/32388/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>