You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/10/28 17:54:36 UTC
[GitHub] [netbeans] lkishalmi opened a new pull request #2498: WIP: Removed primitive wrapper constructor calls from the platform cluster
lkishalmi opened a new pull request #2498:
URL: https://github.com/apache/netbeans/pull/2498
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #2498: WIP: Removed primitive wrapper constructor calls from the platform cluster
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #2498:
URL: https://github.com/apache/netbeans/pull/2498#issuecomment-1008052799
Well, there is another problem with this PR. It breaks the unit tests.
Especially the clipboard related ones.
Anyway, I'm going to rebase this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #2498: WIP: Removed primitive wrapper constructor calls from the platform cluster
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #2498:
URL: https://github.com/apache/netbeans/pull/2498#issuecomment-1008102787
travis has the following tests failing atm (might be all lookup related):
```
org.netbeans.jellytools.QuestionDialogOperatorTest
failed: testConstructorWithParameter name
org.netbeans.core.windows.services.DialogDisplayer128399Test
failed: testDefaultOptionWithStandardOk
org.openide.util.lookup.AbstractLookupArrayStorageTest
failed: testReplaceByEqualInstance name
org.openide.util.lookup.AbstractLookupExecutorTest
failed: testReplaceByEqualInstance name
org.openide.util.lookup.AbstractLookupTest
failed: testReplaceByEqualInstance name
org.openide.util.lookup.ExcludingLookupTest
failed: testReplaceByEqualInstance name
org.openide.util.lookup.LookupsProxyTest
failed: testReplaceByEqualInstance name
org.openide.util.lookup.ProxyLookupTest
failed: testReplaceByEqualInstance name
org.openide.util.lookup.ProxyProxyLookupTest
failed: testReplaceByEqualInstance name
org.openide.util.lookup.SimpleProxyLookupIssue42244Test
failed: testReplaceByEqualInstance name
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #2498: WIP: Removed primitive wrapper constructor calls from the platform cluster
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #2498:
URL: https://github.com/apache/netbeans/pull/2498#issuecomment-1048086871
Closing in favor of #3656
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #2498: WIP: Removed primitive wrapper constructor calls from the platform cluster
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #2498:
URL: https://github.com/apache/netbeans/pull/2498#issuecomment-1008173137
the lookup tests use Integers for object equality/identity checks. Its probably better to revert them since any replacement of `new Integer` will likely break them. They have to be rewritten using something which isn't a cached number (e.g BigInteger or a proper test object with equals/hashcode etc implemented).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #2498: WIP: Removed primitive wrapper constructor calls from the platform cluster
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #2498:
URL: https://github.com/apache/netbeans/pull/2498#issuecomment-963050577
I went through the commits and it looks good to me.
Do you think there is a chance to rebase this? Would be nice to get this in early for NB 13 to avoid it conflicting again. This would fix a lot of deprecation warnings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on pull request #2498: WIP: Removed primitive wrapper constructor calls from the platform cluster
Posted by GitBox <gi...@apache.org>.
BradWalker commented on pull request #2498:
URL: https://github.com/apache/netbeans/pull/2498#issuecomment-1048094747
Hey @lkishalmi , your work was good. But, more encompassing than what I was working on.
Okay with you if I pick up where you stopped and moved forward with it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #2498: WIP: Removed primitive wrapper constructor calls from the platform cluster
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #2498:
URL: https://github.com/apache/netbeans/pull/2498#issuecomment-1048110084
That's fine for me. I'm not planning to work on this anytime soon. I have 2-3 new Gradle stuff in my queue I would like to focus on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #2498: WIP: Removed primitive wrapper constructor calls from the platform cluster
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #2498:
URL: https://github.com/apache/netbeans/pull/2498#issuecomment-1008031643
@lkishalmi this has only one small conflict. Could you rebase this so we can merge it? Even if this PR is still wip, it does not have to cover all cases, other PRs can deliver the rest incrementally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi closed pull request #2498: WIP: Removed primitive wrapper constructor calls from the platform cluster
Posted by GitBox <gi...@apache.org>.
lkishalmi closed pull request #2498:
URL: https://github.com/apache/netbeans/pull/2498
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists