You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2022/09/09 03:01:29 UTC
[GitHub] [logging-log4cxx] swebb2066 opened a new pull request, #122: APR termination must be after destruction of all log4cxx objects
swebb2066 opened a new pull request, #122:
URL: https://github.com/apache/logging-log4cxx/pull/122
As the APRInitializer class has member variables whose destructors call apr_* functions, apr_terminate() cannot be called the the APRInitializer class destructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4cxx] swebb2066 merged pull request #122: APR termination must be after destruction of all log4cxx objects
Posted by GitBox <gi...@apache.org>.
swebb2066 merged PR #122:
URL: https://github.com/apache/logging-log4cxx/pull/122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4cxx] swebb2066 closed pull request #122: APR termination must be after destruction of all log4cxx objects
Posted by GitBox <gi...@apache.org>.
swebb2066 closed pull request #122: APR termination must be after destruction of all log4cxx objects
URL: https://github.com/apache/logging-log4cxx/pull/122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4cxx] swebb2066 commented on pull request #122: APR termination must be after destruction of all log4cxx objects
Posted by GitBox <gi...@apache.org>.
swebb2066 commented on PR #122:
URL: https://github.com/apache/logging-log4cxx/pull/122#issuecomment-1242583461
You were correct to be concerned about the comment on adding/removing appenders.
A FallbackErrorHandler that holds the same logger that caused the fall back would have resulted in a deadlock.
The latest commit should fix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4cxx] swebb2066 commented on pull request #122: APR termination must be after destruction of all log4cxx objects
Posted by GitBox <gi...@apache.org>.
swebb2066 commented on PR #122:
URL: https://github.com/apache/logging-log4cxx/pull/122#issuecomment-1242561934
A stack trace of a crash in mutithreadtest (after hundreds of instatiations) - see [LOGCXX-532](https://issues.apache.org/jira/projects/LOGCXX/issues/LOGCXX-532?filter=allopenissues) - indicates the cause of the crash is likely to be independent of log4cxx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4cxx] rm5248 commented on pull request #122: APR termination must be after destruction of all log4cxx objects
Posted by GitBox <gi...@apache.org>.
rm5248 commented on PR #122:
URL: https://github.com/apache/logging-log4cxx/pull/122#issuecomment-1242219664
This looks good to me.
I was concerned about the comment on adding/removing appenders if there is a problem and I added a new test for that. It doesn't appear to be an issue. commit: https://github.com/apache/logging-log4cxx/commit/cb96ae91fd73e94bcf34a06077e991b9ae477fdc
Note that when I first ran your branch, it did segfault on the multithread test. As long as it's not 100% of the time, I'm not too concerned about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org