[jira] [Commented] (THRIFT-3606) TSaslClientTransport props typed too strongly

["John Sirois (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-3606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140935#comment-15140935 ] 

John Sirois commented on THRIFT-3606:
-------------------------------------

[~nattobean], this sounds totally reasonable to me.  Are you willing to send up a patch?  There are 2 methods described here: https://thrift.apache.org/docs/HowToContribute

> TSaslClientTransport props typed too strongly
> ---------------------------------------------
>
>                 Key: THRIFT-3606
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3606
>             Project: Thrift
>          Issue Type: Bug
>          Components: Java - Library
>    Affects Versions: 0.9.3
>            Reporter: David Schreibman
>            Priority: Minor
>
> The constructor in TSaslClientTransport.java with signature:
> public TSaslClientTransport(
>   String mechanism,
>   String authorizationId, String protocol,
>   String serverName,
>   Map<String, String> props,
>   CallbackHandler cbh,
>   TTransport transport)
> Is passing along the props Map to Sasl.createSaslClient(....). However, createSaslClient actually accepts props as Map<String, ?>. Having the props as Map<String, String> means that we cannot pass legitimate non-string property values. For example, you cannot pass in the JGSS javax.security.sasl.policy.credentials property which is an object of type GSSCredential.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)