[GitHub] [spark] MyeongKim commented on a change in pull request #33544: [SPARK-34927][INFRA] Support TPCDSQueryBenchmark in Benchmarks

[GitBox <gi...@apache.org>]

MyeongKim commented on a change in pull request #33544:
URL: https://github.com/apache/spark/pull/33544#discussion_r683832027



##########
File path: .github/workflows/benchmark.yml
##########
@@ -19,32 +19,108 @@ on:
         description: 'Number of job splits'
         required: true
         default: '1'
+      run-tcp-ds-query-benchmark:
+        description: 'Run TPCDSQueryBenchmark: true or false'
+        required: false
+        default: 'false'
 
 jobs:
   matrix-gen:
     name: Generate matrix for job splits
     runs-on: ubuntu-20.04
     outputs:
-      matrix: ${{ steps.set-matrix.outputs.matrix }}
+      class: ${{ steps.set-matrix.outputs.class }}
+      split: ${{ steps.set-matrix.outputs.split }}
+      num-split: ${{ steps.set-matrix.outputs.num-split }}

Review comment:
       yes. right I think your approach is simpler. removed the matrix dimension  




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org