You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/25 12:22:29 UTC
[GitHub] [airflow] potiuk opened a new pull request #12614: Fixes inconsistent behaviour of utf8mb4 encoding on Mysql 5.7/8
potiuk opened a new pull request #12614:
URL: https://github.com/apache/airflow/pull/12614
Client encding behaviour works differently in MySQL 5.7 and 8.
This is described in detail in
https://dev.mysql.com/doc/refman/8.0/en/charset-connection.html
But it seems that when client encoding is specified as utf8mb4,
the defult collation used by client 8 is not recognized
and it fallbacks to the default encoding on the server which
is latin1 on MySQL 5.7.
This change does the following:
* changes the client encodign to be utf8
* forces the default on database server to be utf8mb4 - regardless if
MySQL 5.7 or MySQL8 is used
This way both client and server encoding will match on both
mysql8 and mysql 5.7. Client
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12614: Fixes inconsistent behaviour of utf8mb4 encoding on Mysql 5.7/8
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12614:
URL: https://github.com/apache/airflow/pull/12614#issuecomment-733711257
Initialization and most tests work. Merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #12614: Fixes inconsistent behaviour of utf8mb4 encoding on Mysql 5.7/8
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #12614:
URL: https://github.com/apache/airflow/pull/12614
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12614: Fixes inconsistent behaviour of utf8mb4 encoding on Mysql 5.7/8
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12614:
URL: https://github.com/apache/airflow/pull/12614#issuecomment-733703445
The PR needs to run all tests because it modifies core of Airflow! Please rebase it to latest master or ask committer to re-run it!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org