You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by SteveKing <st...@gmx.ch> on 2005/05/01 16:46:19 UTC

make svn_client__open_ra_session() public (or: how to easily get a session)

Hi,

For functions like svn_ra_get_locks() or svn_ra_get_repos_root() an 
svn_ra_session_t object is needed. Currently, I'm using 
svn_client__open_ra_session() to get such a session object. I know that 
this function isn't public and shouldn't be used directly by clients, 
but I haven't found an easier way.
So my request: could you make svn_client__open_ra_session a public 
function or tell me how to create a session object with a public API?

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: make svn_client__open_ra_session() public (or: how to easily get a session)

Posted by "Peter N. Lundblad" <pe...@famlundblad.se>.
On Sun, 1 May 2005, Ben Collins-Sussman wrote:

>
> On May 1, 2005, at 12:02 PM, SteveKing wrote:
>
> > Ben Collins-Sussman wrote:
> >> On May 1, 2005, at 11:46 AM, SteveKing wrote:
> >>> Hi,
> >>>
> >>> For functions like svn_ra_get_locks() or svn_ra_get_repos_root() an
> >>> svn_ra_session_t object is needed. Currently, I'm using
> >>> svn_client__open_ra_session() to get such a session object. I know
> >>> that this function isn't public and shouldn't be used directly by
> >>> clients, but I haven't found an easier way.
> >>> So my request: could you make svn_client__open_ra_session a public
> >>> function or tell me how to create a session object with a public
> >>> API?
> >>>
> >> Um, it's the very first public function in svn_ra.h:  svn_ra_open().
> >>  :-)
> >> Have you never used svn_ra.h before?  I don't understand.
> >> svn_ra_open() has always been the foundation, the first thing you
> >> need to call before any other RA function...?
> >
> > Well, yes I've seen that one. But: svn_client__open_ra_session() is
> > _much_ easier to use because it takes an svn_client_ctx_t structure
> > instead of an svn_ra_callbacks_t structure.
>
> True.  Perhaps we should make that function public after all, it sounds
> like it would be more convenient.
>
+1. In 1.3.

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: make svn_client__open_ra_session() public (or: how to easily get a session)

Posted by Greg Hudson <gh...@MIT.EDU>.
On Sun, 2005-05-01 at 13:39, Ben Collins-Sussman wrote:
> True.  Perhaps we should make that function public after all, it sounds 
> like it would be more convenient.

It also seems wrong that an application should have to redo the
gluing-together of libsvn_ra and libsvn_wc which is done by that
function.  (Really.  Take a look at libsvn_client/ra.c; there are over
200 lines of code involved.)

Of course, if we got rid of wcprops and synthesized version resources,
there'd be a lot less of that to do...


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: make svn_client__open_ra_session() public (or: how to easily get a session)

Posted by Ben Collins-Sussman <su...@collab.net>.
On May 1, 2005, at 12:02 PM, SteveKing wrote:

> Ben Collins-Sussman wrote:
>> On May 1, 2005, at 11:46 AM, SteveKing wrote:
>>> Hi,
>>>
>>> For functions like svn_ra_get_locks() or svn_ra_get_repos_root() an 
>>> svn_ra_session_t object is needed. Currently, I'm using 
>>> svn_client__open_ra_session() to get such a session object. I know 
>>> that this function isn't public and shouldn't be used directly by 
>>> clients, but I haven't found an easier way.
>>> So my request: could you make svn_client__open_ra_session a public 
>>> function or tell me how to create a session object with a public 
>>> API?
>>>
>> Um, it's the very first public function in svn_ra.h:  svn_ra_open().  
>>  :-)
>> Have you never used svn_ra.h before?  I don't understand.  
>> svn_ra_open() has always been the foundation, the first thing you 
>> need to call before any other RA function...?
>
> Well, yes I've seen that one. But: svn_client__open_ra_session() is 
> _much_ easier to use because it takes an svn_client_ctx_t structure 
> instead of an svn_ra_callbacks_t structure.

True.  Perhaps we should make that function public after all, it sounds 
like it would be more convenient.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: make svn_client__open_ra_session() public (or: how to easily get a session)

Posted by SteveKing <st...@gmx.ch>.
Ben Collins-Sussman wrote:
> 
> On May 1, 2005, at 11:46 AM, SteveKing wrote:
> 
>> Hi,
>>
>> For functions like svn_ra_get_locks() or svn_ra_get_repos_root() an 
>> svn_ra_session_t object is needed. Currently, I'm using 
>> svn_client__open_ra_session() to get such a session object. I know 
>> that this function isn't public and shouldn't be used directly by 
>> clients, but I haven't found an easier way.
>> So my request: could you make svn_client__open_ra_session a public 
>> function or tell me how to create a session object with a public API?
>>
> 
> Um, it's the very first public function in svn_ra.h:  svn_ra_open().   :-)
> 
> Have you never used svn_ra.h before?  I don't understand.  svn_ra_open() 
> has always been the foundation, the first thing you need to call before 
> any other RA function...?

Well, yes I've seen that one. But: svn_client__open_ra_session() is 
_much_ easier to use because it takes an svn_client_ctx_t structure 
instead of an svn_ra_callbacks_t structure. And since most API calls I 
use are svn_client_* ones, I already have an svn_client_ctx_t object 
ready to pass to them. With svn_ra_callbacks_t, I'd have to create a new 
object just for the svn_ra_* calls.

Well, I guess I have to get over it and just create an 
svn_ra_callbacks_t object...

And thanks for the quick answer.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: make svn_client__open_ra_session() public (or: how to easily get a session)

Posted by Ben Collins-Sussman <su...@collab.net>.
On May 1, 2005, at 11:46 AM, SteveKing wrote:

> Hi,
>
> For functions like svn_ra_get_locks() or svn_ra_get_repos_root() an 
> svn_ra_session_t object is needed. Currently, I'm using 
> svn_client__open_ra_session() to get such a session object. I know 
> that this function isn't public and shouldn't be used directly by 
> clients, but I haven't found an easier way.
> So my request: could you make svn_client__open_ra_session a public 
> function or tell me how to create a session object with a public API?
>

Um, it's the very first public function in svn_ra.h:  svn_ra_open().   
:-)

Have you never used svn_ra.h before?  I don't understand.  
svn_ra_open() has always been the foundation, the first thing you need 
to call before any other RA function...?


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org