You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2022/03/21 07:22:00 UTC
[GitHub] [james-project] chibenwa commented on a change in pull request #923: Upgraded from Legacy JavaMail to Jakarta Mail 2.0.1/Activation 2.0.1
chibenwa commented on a change in pull request #923:
URL: https://github.com/apache/james-project/pull/923#discussion_r830792088
##########
File path: mailbox/api/src/main/java/org/apache/james/mailbox/MessageIdManager.java
##########
@@ -23,7 +23,7 @@
import java.util.List;
import java.util.Set;
-import javax.mail.Flags;
+import jakarta.mail.Flags;
Review comment:
This breaking change on the `mailbox-api` needs to be documented.
This should be done via an entry within `upgrade-instructions.md` telling that people writing mailets needs to change their imports.
##########
File path: mailet/api/src/main/java/org/apache/mailet/Mail.java
##########
@@ -28,8 +28,8 @@
import java.util.Optional;
import java.util.stream.Stream;
-import javax.mail.MessagingException;
-import javax.mail.internet.MimeMessage;
+import jakarta.mail.MessagingException;
+import jakarta.mail.internet.MimeMessage;
Review comment:
This breaking change on the Mail API needs to be documented.
This should be done via an entry within `upgrade-instructions.md` telling that people writing mailets needs to change their imports.
##########
File path: pom.xml
##########
@@ -2186,17 +2182,17 @@
</dependency>
<dependency>
<groupId>com.sun.activation</groupId>
- <artifactId>javax.activation</artifactId>
- <version>1.2.0</version>
+ <artifactId>jakarta.activation</artifactId> <!-- Replaces 'com.sun.activation:javax.activation' -->
Review comment:
Do we need this comment?
##########
File path: pom.xml
##########
@@ -2186,17 +2182,17 @@
</dependency>
<dependency>
<groupId>com.sun.activation</groupId>
- <artifactId>javax.activation</artifactId>
- <version>1.2.0</version>
+ <artifactId>jakarta.activation</artifactId> <!-- Replaces 'com.sun.activation:javax.activation' -->
+ <version>${jakarta-activation.version}</version>
</dependency>
<dependency>
<groupId>com.sun.mail</groupId>
- <artifactId>javax.mail</artifactId>
- <version>1.6.2</version>
+ <artifactId>jakarta.mail</artifactId> <!-- Replaces 'com.sun.mail:javax.mail' -->
Review comment:
Do we need this comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org