[GitHub] [shardingsphere] tristaZero commented on a change in pull request #7559: Refactor change unconfiguredSchemaMetaDataMap type to Map>

[GitBox <gi...@apache.org>]

tristaZero commented on a change in pull request #7559:
URL: https://github.com/apache/shardingsphere/pull/7559#discussion_r493183436



##########
File path: shardingsphere-governance/shardingsphere-governance-core/shardingsphere-governance-core-common/src/main/java/org/apache/shardingsphere/governance/core/yaml/swapper/RuleSchemaMetaDataYamlSwapper.java
##########
@@ -47,22 +47,26 @@ public YamlRuleSchemaMetaData swapToYamlConfiguration(final RuleSchemaMetaData m
         YamlRuleSchemaMetaData result = new YamlRuleSchemaMetaData();
         result.setConfiguredSchemaMetaData(convertYamlSchema(metaData.getConfiguredSchemaMetaData()));
         Map<String, YamlSchemaMetaData> unconfigured = metaData.getUnconfiguredSchemaMetaDataMap().entrySet().stream()
-                .collect(Collectors.toMap(Entry::getKey, entry -> convertYamlSchema(entry.getValue())));

Review comment:
       Do you think the following change is possible?
   
   ```java
   //  YamlRuleSchemaMetaData
   
   private Map<String, YamlSchemaMetaData> unconfiguredSchemaMetaDataMap;
   
   to
   
   private Map<String, Collection<String>> unconfiguredSchemaMetaDataMap;
   ```
   
   Since a similar change is made in `RuleSchemaMetaData`, I suppose it will be better to keep `YamlRuleSchemaMetaData `  and `RuleSchemaMetaData` same. 
   
   What do you think? FYI, please note this change will also alter the content for the registry center (`SchemaChangedListener` will be involved)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org