[GitHub] [skywalking] Frefreak commented on issue #5997: agent side percentage sampling config option

[GitBox <gi...@apache.org>]

Frefreak commented on issue #5997:
URL: https://github.com/apache/skywalking/issues/5997#issuecomment-743723779


   Hi, thanks for the timely response. One of our use case is with MQ like Kafka. 
   My previous understanding is that if I only set `sampleRate` for server side, the headers will still be added for every message and stored in Kafka brokers (kafka storage and the traffic for sending it to brokers are not affected by this option, so the overhead may be un-negligible under a high amount of throughput). That's why I want a "client side" sampling. I'm not very sure of this behavior so please correct me if this is not the fact.
   
   The sample n in 3 seconds client config works for us, but a percentage one would be easier to  reason about when specifying this option since different topics may have different  messages per seconds, in which case a percentage sampling rate seems more suitable.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org