You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "James Nord (JIRA)" <ji...@codehaus.org> on 2010/07/27 17:08:32 UTC
[jira] Created: (SCM-565) scm:validate should not fork the build
scm:validate should not fork the build
--------------------------------------
Key: SCM-565
URL: http://jira.codehaus.org/browse/SCM-565
Project: Maven SCM
Issue Type: Improvement
Affects Versions: 1.3
Reporter: James Nord
scm:validate invokes the lifecycle validate prior to calling itself.
but this adds no benifit and just slows down the build (esp if scm:validate is bound to the validate phase!)
That is scm:validate should only be validating the scm information in the POM - if other plugins such as the enforcer fail due to incorrect deps this should not cause mvn:validate to fail!
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (SCM-565) scm:validate should not fork the build
Posted by "Robert Scholte (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/SCM-565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=317228#comment-317228 ]
Robert Scholte commented on SCM-565:
------------------------------------
Looking at the current state of the [ValidateMojo|http://maven.apache.org/scm/maven-scm-plugin/xref/org/apache/maven/scm/plugin/ValidateMojo.html] I don't recognize your issue. Can we close it?
> scm:validate should not fork the build
> --------------------------------------
>
> Key: SCM-565
> URL: https://jira.codehaus.org/browse/SCM-565
> Project: Maven SCM
> Issue Type: Improvement
> Components: maven-plugin
> Affects Versions: 1.3
> Reporter: James Nord
>
> {{scm:validate}} invokes the lifecycle validate prior to calling itself.
> but this adds no benifit and just slows down the build (esp if {{scm:validate}} is bound to the validate phase!)
> That is {{scm:validate}} should only be validating the scm information in the POM - if other plugins such as the enforcer fail due to incorrect deps this should not cause {{mvn:validate}} to fail!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (SCM-565) scm:validate should not fork the build
Posted by "James Nord (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/SCM-565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=317313#comment-317313 ]
James Nord commented on SCM-565:
--------------------------------
thanks
> scm:validate should not fork the build
> --------------------------------------
>
> Key: SCM-565
> URL: https://jira.codehaus.org/browse/SCM-565
> Project: Maven SCM
> Issue Type: Improvement
> Components: maven-plugin
> Affects Versions: 1.3
> Reporter: James Nord
> Assignee: Robert Scholte
> Fix For: 1.9
>
>
> {{scm:validate}} invokes the lifecycle validate prior to calling itself.
> but this adds no benifit and just slows down the build (esp if {{scm:validate}} is bound to the validate phase!)
> That is {{scm:validate}} should only be validating the scm information in the POM - if other plugins such as the enforcer fail due to incorrect deps this should not cause {{mvn:validate}} to fail!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (SCM-565) scm:validate should not fork the build
Posted by "Robert Scholte (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/SCM-565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Scholte closed SCM-565.
------------------------------
Resolution: Fixed
Fix Version/s: 1.9
Assignee: Robert Scholte
Fixed in [64d2d326|http://git-wip-us.apache.org/repos/asf/maven-scm/commit/64d2d326]
(I'm already used to the Mojo Annotations, just misread the doclet-tag)
> scm:validate should not fork the build
> --------------------------------------
>
> Key: SCM-565
> URL: https://jira.codehaus.org/browse/SCM-565
> Project: Maven SCM
> Issue Type: Improvement
> Components: maven-plugin
> Affects Versions: 1.3
> Reporter: James Nord
> Assignee: Robert Scholte
> Fix For: 1.9
>
>
> {{scm:validate}} invokes the lifecycle validate prior to calling itself.
> but this adds no benifit and just slows down the build (esp if {{scm:validate}} is bound to the validate phase!)
> That is {{scm:validate}} should only be validating the scm information in the POM - if other plugins such as the enforcer fail due to incorrect deps this should not cause {{mvn:validate}} to fail!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (SCM-565) scm:validate should not fork the build
Posted by "Robert Scholte (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/SCM-565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Scholte updated SCM-565:
-------------------------------
Component/s: maven-plugin
Description:
{{scm:validate}} invokes the lifecycle validate prior to calling itself.
but this adds no benifit and just slows down the build (esp if {{scm:validate}} is bound to the validate phase!)
That is {{scm:validate}} should only be validating the scm information in the POM - if other plugins such as the enforcer fail due to incorrect deps this should not cause {{mvn:validate}} to fail!
was:
scm:validate invokes the lifecycle validate prior to calling itself.
but this adds no benifit and just slows down the build (esp if scm:validate is bound to the validate phase!)
That is scm:validate should only be validating the scm information in the POM - if other plugins such as the enforcer fail due to incorrect deps this should not cause mvn:validate to fail!
> scm:validate should not fork the build
> --------------------------------------
>
> Key: SCM-565
> URL: https://jira.codehaus.org/browse/SCM-565
> Project: Maven SCM
> Issue Type: Improvement
> Components: maven-plugin
> Affects Versions: 1.3
> Reporter: James Nord
>
> {{scm:validate}} invokes the lifecycle validate prior to calling itself.
> but this adds no benifit and just slows down the build (esp if {{scm:validate}} is bound to the validate phase!)
> That is {{scm:validate}} should only be validating the scm information in the POM - if other plugins such as the enforcer fail due to incorrect deps this should not cause {{mvn:validate}} to fail!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (SCM-565) scm:validate should not fork the build
Posted by "James Nord (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/SCM-565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=317276#comment-317276 ]
James Nord commented on SCM-565:
--------------------------------
I see the issue still?
http://maven.apache.org/scm/maven-scm-plugin/xref/org/apache/maven/scm/plugin/ValidateMojo.html
34 * @execute phase="validate"
http://maven.apache.org/developers/mojo-api-specification.html
execute
When this goal is invoked, it will first invoke a parallel lifecycle, ending at the given phase.
So when scm:validate is bound to the lifecycle validate phase will be run twice.
[INFO] Preparing scm:validate
[WARNING] Removing: validate from forked lifecycle, to prevent recursive invocation.
> scm:validate should not fork the build
> --------------------------------------
>
> Key: SCM-565
> URL: https://jira.codehaus.org/browse/SCM-565
> Project: Maven SCM
> Issue Type: Improvement
> Components: maven-plugin
> Affects Versions: 1.3
> Reporter: James Nord
>
> {{scm:validate}} invokes the lifecycle validate prior to calling itself.
> but this adds no benifit and just slows down the build (esp if {{scm:validate}} is bound to the validate phase!)
> That is {{scm:validate}} should only be validating the scm information in the POM - if other plugins such as the enforcer fail due to incorrect deps this should not cause {{mvn:validate}} to fail!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira