[GitHub] [spark] xkrogen edited a comment on pull request #31936: [SPARK-34828][YARN] Make shuffle service name configurable on client side and allow for classpath-based config override on server side

[GitBox <gi...@apache.org>]

xkrogen edited a comment on pull request #31936:
URL: https://github.com/apache/spark/pull/31936#issuecomment-807168081


   I went through the logs for the [most recent test failure](https://github.com/apache/spark/pull/31936/checks?check_run_id=2193694302) and couldn't find any test failures:
   ```
   > grep -E -e "completed.+aborted" -e "Passed.+Failed" 6_Build\ modules\ sql\ -\ slow\ tests\ \(JDK\ 8,\ hadoop3.2,\ hive2.3\).txt
   2021-03-25T15:45:53.5726513Z [info] Suites: completed 423, aborted 0
   2021-03-25T15:45:53.5834071Z [info] Passed: Total 1062, Failed 0, Errors 0, Passed 1062, Ignored 1
   ```
   (I had to download the logs since they were too big for the GitHub web viewer).
   
   Not sure what's wrong but this same suite passed on my previous build with only documentation changes since then (the previous failure was in a different module).
   
   > Just to clarify did you test this on both a Hadoop < 2.9 and > 2.9 version? It sounds like you probably did but double checking.
   
   @tgravescs  -- I think I did test on a Hadoop 2.7 cluster previously, but just to be sure, I tried just now. Works great using a custom shuffle service name and conf overlay via `spark-shuffle-site.xml`. And I have tested on a Hadoop 2.10 cluster which is where I was doing the multiple-ESS testing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org