[GitHub] xrmx commented on a change in pull request #3459: Sqllab dont send empty queries to db

[gi...@git.apache.org]

xrmx commented on a change in pull request #3459: Sqllab  dont send empty queries to db
URL: https://github.com/apache/incubator-superset/pull/3459#discussion_r138728401
 
 

 ##########
 File path: superset/assets/javascripts/SqlLab/components/SqlEditor.jsx
 ##########
 @@ -76,7 +76,9 @@ class SqlEditor extends React.PureComponent {
     if (!this.props.database.allow_run_sync) {
       effectiveRunAsync = true;
     }
-    this.startQuery(effectiveRunAsync);
+    if (this.props.queryEditor.sql) {
 
 Review comment:
   If that's the right place to add it, maybe an early return at the top of the function instead? 
   
   ```
   if (!this.props.queryEditor.sql)
       return;
   ```
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services