[jira] [Commented] (CB-5770) cordova define statement that wraps plugin JS files potentially is commented out unintentionally

["Josh Bavari (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-5770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13868324#comment-13868324 ] 

Josh Bavari commented on CB-5770:
---------------------------------

The Pull request for CB-5770 is: https://github.com/apache/cordova-plugman/pull/42

> cordova define statement that wraps plugin JS files potentially is commented out unintentionally
> ------------------------------------------------------------------------------------------------
>
>                 Key: CB-5770
>                 URL: https://issues.apache.org/jira/browse/CB-5770
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugman
>    Affects Versions: 3.1.0, 3.2.0, 3.3.0
>         Environment: Mac OSX v10.8.5
>            Reporter: Josh Bavari
>            Priority: Minor
>              Labels: plugin, plugins
>             Fix For: 3.4.0
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> When adding plugins with plugman, the process wraps the containing javascript content with the following:
> cordova.define("moduleName", function(require, exports, module) {
>   scriptContent 
> });
> If a plugin JS file has a comment at the end of the file that plugman is wrapping with a cordova.define statement, the string that is concatenated at the end, "});", may be commented out.
> For example, given the original plugin file before preparing:
> var module = { .. code .. };
> //Some comment comes here
> The file after preparing:
> cordova.define("moduleName", function(require, exports, module) { 
> var module = { .. code .. };
> //Some comment comes here });
> The fix is to add a new line before placing the end bracket and parenthesis.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)