You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/07 15:13:41 UTC

[GitHub] [flink] twalthr commented on pull request #14309: [FLINK-20485][table] Improve performance of data views

twalthr commented on pull request #14309:
URL: https://github.com/apache/flink/pull/14309#issuecomment-739979840


   Thanks for the review @wuchong. I removed some unused code in another commit.
   
   Regarding 1: `DistinctViewSpec` is not really necessary but might help to improve code readability and gives this special `MapView` a name.
   
   Regarding 2: The RAW type is an internal optimization and should not be exposed via API. A `MapView` is a structured type but with a special meaning. However, it can also be used in regular POJOs etc.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org