You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Ted Yu (JIRA)" <ji...@apache.org> on 2018/02/01 17:42:00 UTC
[jira] [Commented] (HBASE-19133) Transfer big cells or
upserted/appended cells into MSLAB upon flattening to CellChunkMap
[ https://issues.apache.org/jira/browse/HBASE-19133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16348983#comment-16348983 ]
Ted Yu commented on HBASE-19133:
--------------------------------
[~galish]:
In Segment.java , line 176, forceCopyOfBigCellInto() is called:
{code}
at org.apache.hadoop.hbase.regionserver.Segment.maybeCloneWithAllocator(Segment.java:176)
at org.apache.hadoop.hbase.regionserver.CellChunkImmutableSegment.copyCellIntoMSLAB(CellChunkImmutableSegment.java:261)
at org.apache.hadoop.hbase.regionserver.CellChunkImmutableSegment.initializeCellSet(CellChunkImmutableSegment.java:122)
{code}
If this.memStoreLAB is of ImmutableMemStoreLAB, the clone cannot be performed.
Should we check the type of this.memStoreLAB in CellChunkImmutableSegment#copyCellIntoMSLAB() ?
> Transfer big cells or upserted/appended cells into MSLAB upon flattening to CellChunkMap
> ----------------------------------------------------------------------------------------
>
> Key: HBASE-19133
> URL: https://issues.apache.org/jira/browse/HBASE-19133
> Project: HBase
> Issue Type: Sub-task
> Reporter: Anastasia Braginsky
> Assignee: Gali Sheffi
> Priority: Major
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19133-V01.patch, HBASE-19133-V02.patch, HBASE-19133-V03.patch, HBASE-19133.01.patch, HBASE-19133.02.patch, HBASE-19133.03.patch, HBASE-19133.04.patch, HBASE-19133.05.patch, HBASE-19133.06.patch, HBASE-19133.07.patch, HBASE-19133.08.patch, HBASE-19133.09.patch, HBASE-19133.10.patch, HBASE-19133.11.patch
>
>
> CellChunkMap Segment index requires all cell data to be written in the MSLAB Chunks. Eventhough MSLAB is enabled, cells bigger than chunk size or upserted/incremented/appended cells are still allocated on the JVM stack. If such cells are found in the process of flattening into CellChunkMap (in-memory-flush) they need to be copied into MSLAB.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)