You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/12 06:57:00 UTC
[GitHub] [spark] turboFei opened a new pull request #27545:
[SPARK-29542][FOLLOW-UP] Keep the description of spark.sql.files.* in
tuning guide be consistent with that of SQLConf.
turboFei opened a new pull request #27545: [SPARK-29542][FOLLOW-UP] Keep the description of spark.sql.files.* in tuning guide be consistent with that of SQLConf.
URL: https://github.com/apache/spark/pull/27545
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
In this PR, I modify the description of spark.sql.files.* in sql-performance-tuning.md to keep consistent with that in SQLConf.
### Why are the changes needed?
To keep consistent with the description in SQLConf.
### Does this PR introduce any user-facing change?
No, It just
### How was this patch tested?
Existed UT.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #27545:
[SPARK-29542][FOLLOW-UP] Keep the description of spark.sql.files.* in
tuning guide be consistent with that in SQLConf.
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #27545: [SPARK-29542][FOLLOW-UP] Keep the description of spark.sql.files.* in tuning guide be consistent with that in SQLConf.
URL: https://github.com/apache/spark/pull/27545
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27545:
[SPARK-29542][FOLLOW-UP] Keep the description of spark.sql.files.* in
tuning guide be consistent with that of SQLConf.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27545: [SPARK-29542][FOLLOW-UP] Keep the description of spark.sql.files.* in tuning guide be consistent with that of SQLConf.
URL: https://github.com/apache/spark/pull/27545#issuecomment-585059839
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27545:
[SPARK-29542][FOLLOW-UP] Keep the description of spark.sql.files.* in
tuning guide be consistent with that in SQLConf.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27545: [SPARK-29542][FOLLOW-UP] Keep the description of spark.sql.files.* in tuning guide be consistent with that in SQLConf.
URL: https://github.com/apache/spark/pull/27545#issuecomment-585071360
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118282/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27545:
[SPARK-29542][FOLLOW-UP] Keep the description of spark.sql.files.* in
tuning guide be consistent with that of SQLConf.
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27545: [SPARK-29542][FOLLOW-UP] Keep the description of spark.sql.files.* in tuning guide be consistent with that of SQLConf.
URL: https://github.com/apache/spark/pull/27545#issuecomment-585067287
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27545:
[SPARK-29542][FOLLOW-UP] Keep the description of spark.sql.files.* in
tuning guide be consistent with that in SQLConf.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27545: [SPARK-29542][FOLLOW-UP] Keep the description of spark.sql.files.* in tuning guide be consistent with that in SQLConf.
URL: https://github.com/apache/spark/pull/27545#issuecomment-585067812
**[Test build #118282 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118282/testReport)** for PR 27545 at commit [`25b3feb`](https://github.com/apache/spark/commit/25b3febbfd94342e6e451b4682ec30ec34ee9308).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27545: [SPARK-29542][FOLLOW-UP]
Keep the description of spark.sql.files.* in tuning guide be consistent
with that in SQLConf.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27545: [SPARK-29542][FOLLOW-UP] Keep the description of spark.sql.files.* in tuning guide be consistent with that in SQLConf.
URL: https://github.com/apache/spark/pull/27545#issuecomment-585071256
**[Test build #118282 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118282/testReport)** for PR 27545 at commit [`25b3feb`](https://github.com/apache/spark/commit/25b3febbfd94342e6e451b4682ec30ec34ee9308).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27545:
[SPARK-29542][FOLLOW-UP] Keep the description of spark.sql.files.* in
tuning guide be consistent with that of SQLConf.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27545: [SPARK-29542][FOLLOW-UP] Keep the description of spark.sql.files.* in tuning guide be consistent with that of SQLConf.
URL: https://github.com/apache/spark/pull/27545#issuecomment-585059449
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27545:
[SPARK-29542][FOLLOW-UP] Keep the description of spark.sql.files.* in
tuning guide be consistent with that of SQLConf.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27545: [SPARK-29542][FOLLOW-UP] Keep the description of spark.sql.files.* in tuning guide be consistent with that of SQLConf.
URL: https://github.com/apache/spark/pull/27545#issuecomment-585068248
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23041/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27545:
[SPARK-29542][FOLLOW-UP] Keep the description of spark.sql.files.* in
tuning guide be consistent with that in SQLConf.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27545: [SPARK-29542][FOLLOW-UP] Keep the description of spark.sql.files.* in tuning guide be consistent with that in SQLConf.
URL: https://github.com/apache/spark/pull/27545#issuecomment-585071360
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118282/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27545:
[SPARK-29542][FOLLOW-UP] Keep the description of spark.sql.files.* in
tuning guide be consistent with that of SQLConf.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27545: [SPARK-29542][FOLLOW-UP] Keep the description of spark.sql.files.* in tuning guide be consistent with that of SQLConf.
URL: https://github.com/apache/spark/pull/27545#issuecomment-585068244
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27545:
[SPARK-29542][FOLLOW-UP] Keep the description of spark.sql.files.* in
tuning guide be consistent with that in SQLConf.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27545: [SPARK-29542][FOLLOW-UP] Keep the description of spark.sql.files.* in tuning guide be consistent with that in SQLConf.
URL: https://github.com/apache/spark/pull/27545#issuecomment-585071348
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27545:
[SPARK-29542][FOLLOW-UP] Keep the description of spark.sql.files.* in
tuning guide be consistent with that in SQLConf.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27545: [SPARK-29542][FOLLOW-UP] Keep the description of spark.sql.files.* in tuning guide be consistent with that in SQLConf.
URL: https://github.com/apache/spark/pull/27545#issuecomment-585071348
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27545:
[SPARK-29542][FOLLOW-UP] Keep the description of spark.sql.files.* in
tuning guide be consistent with that of SQLConf.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27545: [SPARK-29542][FOLLOW-UP] Keep the description of spark.sql.files.* in tuning guide be consistent with that of SQLConf.
URL: https://github.com/apache/spark/pull/27545#issuecomment-585068248
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23041/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27545:
[SPARK-29542][FOLLOW-UP] Keep the description of spark.sql.files.* in
tuning guide be consistent with that of SQLConf.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27545: [SPARK-29542][FOLLOW-UP] Keep the description of spark.sql.files.* in tuning guide be consistent with that of SQLConf.
URL: https://github.com/apache/spark/pull/27545#issuecomment-585059839
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27545:
[SPARK-29542][FOLLOW-UP] Keep the description of spark.sql.files.* in
tuning guide be consistent with that of SQLConf.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27545: [SPARK-29542][FOLLOW-UP] Keep the description of spark.sql.files.* in tuning guide be consistent with that of SQLConf.
URL: https://github.com/apache/spark/pull/27545#issuecomment-585059449
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27545:
[SPARK-29542][FOLLOW-UP] Keep the description of spark.sql.files.* in
tuning guide be consistent with that of SQLConf.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27545: [SPARK-29542][FOLLOW-UP] Keep the description of spark.sql.files.* in tuning guide be consistent with that of SQLConf.
URL: https://github.com/apache/spark/pull/27545#issuecomment-585068244
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27545: [SPARK-29542][FOLLOW-UP]
Keep the description of spark.sql.files.* in tuning guide be consistent
with that of SQLConf.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27545: [SPARK-29542][FOLLOW-UP] Keep the description of spark.sql.files.* in tuning guide be consistent with that of SQLConf.
URL: https://github.com/apache/spark/pull/27545#issuecomment-585067812
**[Test build #118282 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118282/testReport)** for PR 27545 at commit [`25b3feb`](https://github.com/apache/spark/commit/25b3febbfd94342e6e451b4682ec30ec34ee9308).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org