[jira] [Commented] (SOLR-9331) Can we remove ReRankQuery's length constructor argument?

["Joel Bernstein (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-9331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389932#comment-15389932 ] 

Joel Bernstein commented on SOLR-9331:
--------------------------------------

It's been a while since I looked at this code. I'm wondering if I originally implemented like this because of issues with the QueryResultCache. But I don't remember exactly the reason for having a separate length variable. 

> Can we remove ReRankQuery's length constructor argument?
> --------------------------------------------------------
>
>                 Key: SOLR-9331
>                 URL: https://issues.apache.org/jira/browse/SOLR-9331
>             Project: Solr
>          Issue Type: Wish
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Christine Poerschke
>            Priority: Minor
>         Attachments: SOLR-9331.patch
>
>
> Can we remove ReRankQuery's length constructor argument? It is a ReRankQParserPlugin private class.
> proposed patch summary:
> * change ReRankQuery.getTopDocsCollector to use its len argument (instead of the length member)
> * remove ReRankQuery's length member and constructor argument
> * remove ReRankQParser.parse's use of the rows and start parameters
> motivation: towards ReRankQParserPlugin and LTRQParserPlugin (SOLR-8542) sharing (more) code



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org