You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by GitBox <gi...@apache.org> on 2021/02/22 21:56:06 UTC

[GitHub] [datasketches-java] davecromberge commented on pull request #349: Add jaccard similarity capability to Tuple sketches

davecromberge commented on pull request #349:
URL: https://github.com/apache/datasketches-java/pull/349#issuecomment-783701140


   Thank you for taking the time to go through the branch and make the code style changes @leerho.
   
   I think that the use of "final" to prevent inadvertent bugs is a sensible policy, together with the other changes that you have made such as line length.  To ensure that I prevent this in a future submission, I've configured my IDE to use the checkstyle plugin together with the `tools/SketchesCheckstyle.xml` configuration file.  This seems to enforce the style rules that you have referred to, such as the 110-character line limit.
   
   I've also spent some time trying to configure the build POM file to enable a user to run `mvn checkstyle:checkstyle` for the same purpose.  However, it required an additional plugin with upgrade similar to this:
   
   ```
   <build>
      <plugins>
   ....
        <plugin>
             <groupId>org.apache.maven.plugins</groupId>
             <artifactId>maven-checkstyle-plugin</artifactId>
             <version>3.1.2</version>
             <dependencies>
               <dependency>
                 <groupId>com.puppycrawl.tools</groupId>
                 <artifactId>checkstyle</artifactId>
                 <version>8.40</version>
               </dependency>
             </dependencies>
             <configuration>
               <configLocation>${project.basedir}/tools/SketchesCheckstyle.xml</configLocation>
             </configuration>
           </plugin>
   ```
   
   I was unsuccessful at getting this to work, but I'm not sure how useful it would be given that there is an IDE option.  On our projects, we enable a style checker on building a PR, but I think that you have configured similar checks already.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org