You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by macdonst <gi...@git.apache.org> on 2017/06/09 20:24:57 UTC
[GitHub] cordova-plugin-device-orientation pull request #36: CB-12728: Device Orienta...
GitHub user macdonst opened a pull request:
https://github.com/apache/cordova-plugin-device-orientation/pull/36
CB-12728: Device Orientation - SUNSET
### Platforms affected
All
### What does this PR do?
Add's deprecation notice to the repo
### What testing has been done on this change?
n/a
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/macdonst/cordova-plugin-device-orientation deprecated
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-device-orientation/pull/36.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #36
----
commit d9e90ca870ec9a12e2d8fd1cedfea8c5f025e4de
Author: Simon MacDonald <si...@gmail.com>
Date: 2017-06-09T20:13:42Z
CB-12728: Device Orientation - SUNSET
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-device-orientation issue #36: CB-12728: Device Orientation - ...
Posted by cordova-qa <gi...@git.apache.org>.
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-device-orientation/pull/36
Cordova CI Build has completed successfully.
**Commit** - [Link](https://github.com/apache/cordova-plugin-device-orientation/pull/36/commits/d9e90ca870ec9a12e2d8fd1cedfea8c5f025e4de)
**Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-device-orientation-pr/26/)
66 tests run, 9 skipped, 0 failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-device-orientation issue #36: CB-12728: Device Orientation - ...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-plugin-device-orientation/pull/36
lgtm
When we publish it next, we should also deprecate it in npm land.
https://docs.npmjs.com/cli/deprecate
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-device-orientation pull request #36: CB-12728: Device Orienta...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-device-orientation/pull/36
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org