[GitHub] [nifi] markap14 commented on issue #3387: NIFI-6009 ScanKudu Processor & KuduPut Processor Delete Operation

[GitBox <gi...@apache.org>]

markap14 commented on issue #3387: NIFI-6009 ScanKudu Processor & KuduPut Processor Delete Operation
URL: https://github.com/apache/nifi/pull/3387#issuecomment-481362938
 
 
   I have fairly minimal Kudu experience but am very familiar with NiFi so between Grant and myself we should have this covered pretty well. :)
   
   I have not been thoroughly through this PR, but I noticed a significant refactoring into creating a Controller Service. While we do have some processors that use a "client" type of Controller Service, we have to be very careful modifying an existing processor like this to change how this is configured. Doing so would mean that everyone who uses the Kudu processor currently would have an invalid flow when they upgrade and would then have to completely reconfigure everything. We would need to have a really good, defensible argument for changing the processor in that way. Can you explain the rationale behind such a change?
   
   It also appears that you changed the package name from "org.apache.nifi.processors.kudu" to "org.apache.nifi.kudu" - we cannot make a change like this, as it would result in processors that exist in current flows becoming "Ghost Processors."
   
   I also wonder if it makes more sense to have a DeleteKudu processor. PutKudu implies to me that it is going to put data into Kudu, not delete data...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services