You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jaxme-dev@ws.apache.org by ia...@apache.org on 2003/11/13 08:46:20 UTC

cvs commit: ws-jaxme/src/xs/org/apache/ws/jaxme/xs/junit WSDLTest.java

ias         2003/11/12 23:46:20

  Modified:    src/xs/org/apache/ws/jaxme/xs/junit WSDLTest.java
  Log:
  testComprehensiveTypes uses StringBuffer instead of simple concatenation.
  Sun's JDK 1.4.2 (both _01 and _02) can't compile WSDLTest.java with a message that the result of the concatenation is too long for a String constant.
  (According to Dr. Kim, one of my colleagues and specialized in JVM, told me a String constant in a class binary has the limit of 64k.)
  I also think that dealing with (extremely) long String instances, it's better to use a StringBuffer usually for better performance and stability.
  
  Revision  Changes    Path
  1.6       +3 -1      ws-jaxme/src/xs/org/apache/ws/jaxme/xs/junit/WSDLTest.java
  
  Index: WSDLTest.java
  ===================================================================
  RCS file: /home/cvs/ws-jaxme/src/xs/org/apache/ws/jaxme/xs/junit/WSDLTest.java,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- WSDLTest.java	11 Nov 2003 21:13:15 -0000	1.5
  +++ WSDLTest.java	13 Nov 2003 07:46:20 -0000	1.6
  @@ -7136,6 +7136,8 @@
     "</definitions>\n";
   
     public void testComprehensiveTypes() throws Exception {
  -    parseString(comprehensiveTypes1 + comprehensiveTypes2, "ComprehensiveTypes.wsdl");
  +      StringBuffer comprehensiveTypesText = new StringBuffer(comprehensiveTypes1);
  +      comprehensiveTypesText.append(comprehensiveTypes2);
  +      parseString(comprehensiveTypesText.toString(), "ComprehensiveTypes.wsdl");
     }
   }
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: jaxme-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: jaxme-dev-help@ws.apache.org