You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Matt Dailey (Code Review)" <ge...@cloudera.org> on 2016/12/08 02:39:55 UTC
[kudu-CR] KUDU-1780: Unshaded classes in kudu-client jar
Matt Dailey has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5413
Change subject: KUDU-1780: Unshaded classes in kudu-client jar
......................................................................
KUDU-1780: Unshaded classes in kudu-client jar
* shade plugin relocates com.google.thirdparty
to org.apache.kudu.client.shaded.com.google.thirdparty
Change-Id: Idfdb8a5ebaffcafbe50f21de0966035938decc12
---
M java/kudu-client/pom.xml
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/5413/1
--
To view, visit http://gerrit.cloudera.org:8080/5413
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idfdb8a5ebaffcafbe50f21de0966035938decc12
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Matt Dailey <ma...@gmail.com>
[kudu-CR] KUDU-1780: Unshaded classes in kudu-client jar
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1780: Unshaded classes in kudu-client jar
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5413
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idfdb8a5ebaffcafbe50f21de0966035938decc12
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Matt Dailey <ma...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] KUDU-1780: Unshaded classes in kudu-client jar
Posted by "Matt Dailey (Code Review)" <ge...@cloudera.org>.
Hello Todd Lipcon, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5413
to look at the new patch set (#3).
Change subject: KUDU-1780: Unshaded classes in kudu-client jar
......................................................................
KUDU-1780: Unshaded classes in kudu-client jar
* shade plugin relocates com.google.thirdparty
to org.apache.kudu.client.shaded.com.google.thirdparty
* alphabetized relocation in pom
Change-Id: Idfdb8a5ebaffcafbe50f21de0966035938decc12
---
M java/kudu-client/pom.xml
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/5413/3
--
To view, visit http://gerrit.cloudera.org:8080/5413
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idfdb8a5ebaffcafbe50f21de0966035938decc12
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Matt Dailey <ma...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-1780: Unshaded classes in kudu-client jar
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: KUDU-1780: Unshaded classes in kudu-client jar
......................................................................
KUDU-1780: Unshaded classes in kudu-client jar
* shade plugin relocates com.google.thirdparty
to org.apache.kudu.client.shaded.com.google.thirdparty
* alphabetized relocation in pom
Change-Id: Idfdb8a5ebaffcafbe50f21de0966035938decc12
Reviewed-on: http://gerrit.cloudera.org:8080/5413
Tested-by: Todd Lipcon <to...@apache.org>
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M java/kudu-client/pom.xml
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/5413
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idfdb8a5ebaffcafbe50f21de0966035938decc12
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Matt Dailey <ma...@gmail.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-1780: Unshaded classes in kudu-client jar
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1780: Unshaded classes in kudu-client jar
......................................................................
Patch Set 3: Verified+1
build failed from pypi issues, java seemed find
--
To view, visit http://gerrit.cloudera.org:8080/5413
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idfdb8a5ebaffcafbe50f21de0966035938decc12
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Matt Dailey <ma...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] KUDU-1780: Unshaded classes in kudu-client jar
Posted by "Matt Dailey (Code Review)" <ge...@cloudera.org>.
Hello Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5413
to look at the new patch set (#2).
Change subject: KUDU-1780: Unshaded classes in kudu-client jar
......................................................................
KUDU-1780: Unshaded classes in kudu-client jar
* shade plugin relocates com.google.thirdparty
to org.apache.kudu.client.shaded.com.google.thirdparty
* alphabetized relocation in pom
Change-Id: Idfdb8a5ebaffcafbe50f21de0966035938decc12
---
M java/kudu-client/pom.xml
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/5413/2
--
To view, visit http://gerrit.cloudera.org:8080/5413
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idfdb8a5ebaffcafbe50f21de0966035938decc12
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Matt Dailey <ma...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-1780: Unshaded classes in kudu-client jar
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1780: Unshaded classes in kudu-client jar
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5413
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idfdb8a5ebaffcafbe50f21de0966035938decc12
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Matt Dailey <ma...@gmail.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No