[jira] [Comment Edited] (MESOS-4445) Labels equality behavior is wrong

["Neil Conway (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-4445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15159857#comment-15159857 ] 

Neil Conway edited comment on MESOS-4445 at 2/23/16 11:34 PM:
--------------------------------------------------------------

Resolution for now: we documented (https://reviews.apache.org/r/43616/) that duplicate key-value pairs in {{Labels}} are not supported. We can revisit whether to support them (or have the master reject requests containing them as invalid) in the future.


was (Author: neilc):
Resolution for now: we documented that duplicate key-value pairs in {{Labels}} are not supported. We can revisit whether to support them (or have the master reject requests containing them as invalid) in the future.

> Labels equality behavior is wrong
> ---------------------------------
>
>                 Key: MESOS-4445
>                 URL: https://issues.apache.org/jira/browse/MESOS-4445
>             Project: Mesos
>          Issue Type: Bug
>          Components: general
>            Reporter: Neil Conway
>            Assignee: Neil Conway
>            Priority: Minor
>              Labels: labels, mesosphere
>
> {noformat}
> TEST(RevocableResourceTest, LabelSemantics)
> {
>   Labels labels1;
>   Labels labels2;
>   labels1.add_labels()->CopyFrom(createLabel("foo", "bar"));
>   labels1.add_labels()->CopyFrom(createLabel("foo", "bar"));
>   labels2.add_labels()->CopyFrom(createLabel("foo", "bar"));
>   labels2.add_labels()->CopyFrom(createLabel("baz", "qux"));
>   bool eq = (labels1 == labels2);
>   LOG(INFO) << "Equal? " << (eq ? "true" : "false");
> }
> {noformat}
> Output:
> {noformat}
> [ RUN      ] RevocableResourceTest.LabelSemantics
> I0120 13:15:25.207223 2078158848 resources_tests.cpp:1990] Equal? true
> [       OK ] RevocableResourceTest.LabelSemantics (0 ms)
> {noformat}
> This behavior seems pretty problematic.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)