[GitHub] [knox] risdenk commented on a change in pull request #231: KNOX-2128 - Custom DataSource and SQL Commands for KnoxShell and KnoxShellTable

[GitBox <gi...@apache.org>]

risdenk commented on a change in pull request #231: KNOX-2128 - Custom DataSource and SQL Commands for KnoxShell and KnoxShellTable
URL: https://github.com/apache/knox/pull/231#discussion_r363334378
 
 

 ##########
 File path: gateway-shell/src/main/java/org/apache/knox/gateway/shell/table/JDBCKnoxShellTableBuilder.java
 ##########
 @@ -42,16 +40,16 @@ public JDBCKnoxShellTableBuilder username(String username) {
     return this;
   }
 
-  public String username() {
-    return username;
-  }
-
   public JDBCKnoxShellTableBuilder pwd(String pass) {
     this.pass = pass;
     return this;
   }
 
-  public String password() {
+  public String username() {
+    return username;
+  }
+
+  public String pwd() {
 
 Review comment:
   `password()` was changed to `pwd`? Any reason?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services