You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by "big-r81 (via GitHub)" <gi...@apache.org> on 2024/10/17 07:31:25 UTC

[PR] Helper scripts for Windows [couchdb-glazier]

big-r81 opened a new pull request, #40:
URL: https://github.com/apache/couchdb-glazier/pull/40

   Adding two helper scripts for Windows:
   
   - `download_extract_rc.ps1` doing the boring and repetitive work when testing a release. Downloads, checks and extract the source tarball
   - `exclude-tests-win.ps1` can be run to exclude some tests before running `make check`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Helper scripts for Windows [couchdb-glazier]

Posted by "pgj (via GitHub)" <gi...@apache.org>.
pgj commented on PR #40:
URL: https://github.com/apache/couchdb-glazier/pull/40#issuecomment-2419722491

   Do you think it would make sense to mention this tool in the `README` file as well?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Helper scripts for Windows [couchdb-glazier]

Posted by "big-r81 (via GitHub)" <gi...@apache.org>.
big-r81 commented on code in PR #40:
URL: https://github.com/apache/couchdb-glazier/pull/40#discussion_r1805982212


##########
bin/exclude_tests_win.ps1:
##########
@@ -0,0 +1,34 @@
+# Licensed under the Apache License, Version 2.0 (the "License"); you may not
+# use this file except in compliance with the License. You may obtain a copy of
+# the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations under
+# the License.
+
+
+# Helper script for excluding some tests which fail under Windows
+# see https://github.com/apache/couchdb/issues/4398
+
+$ROOT_DIR = "C:\relax\releases\3.4.2\apache-couchdb-3.4.2-RC1"

Review Comment:
   added some parameters and description too



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Helper scripts for Windows [couchdb-glazier]

Posted by "big-r81 (via GitHub)" <gi...@apache.org>.
big-r81 commented on code in PR #40:
URL: https://github.com/apache/couchdb-glazier/pull/40#discussion_r1806317941


##########
bin/download_extract_rc.ps1:
##########
@@ -0,0 +1,89 @@
+# Licensed under the Apache License, Version 2.0 (the "License"); you may not
+# use this file except in compliance with the License. You may obtain a copy of
+# the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations under
+# the License.
+
+
+# Helper script for lazy Windows Developers
+# Downloading, checking and extracting the sources of a rc candidate for Windows
+
+<#
+.SYNOPSIS
+    Little helper script for lazy Windows (Release) Developers
+.DESCRIPTION
+    This command downloads, checks and extract a CouchDB source tarball
+
+    -CouchDBVersion         CouchDB version number to download (default 3.4.2)

Review Comment:
   that sounds logical, updated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Helper scripts for Windows [couchdb-glazier]

Posted by "big-r81 (via GitHub)" <gi...@apache.org>.
big-r81 commented on code in PR #40:
URL: https://github.com/apache/couchdb-glazier/pull/40#discussion_r1804784498


##########
bin/download_extract_rc.ps1:
##########
@@ -0,0 +1,61 @@
+# Licensed under the Apache License, Version 2.0 (the "License"); you may not
+# use this file except in compliance with the License. You may obtain a copy of
+# the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations under
+# the License.
+
+
+# Helper script for lazy Windows Developers
+# Downloading, checking and extracting the sources of a rc candidate for Windows
+
+$DOWNLOAD_VERSION = "3.4.2"

Review Comment:
   Good idea, not my first idea for a first version ;-), but added some parameters!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Helper scripts for Windows [couchdb-glazier]

Posted by "pgj (via GitHub)" <gi...@apache.org>.
pgj commented on code in PR #40:
URL: https://github.com/apache/couchdb-glazier/pull/40#discussion_r1804834002


##########
bin/exclude_tests_win.ps1:
##########
@@ -0,0 +1,34 @@
+# Licensed under the Apache License, Version 2.0 (the "License"); you may not
+# use this file except in compliance with the License. You may obtain a copy of
+# the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations under
+# the License.
+
+
+# Helper script for excluding some tests which fail under Windows
+# see https://github.com/apache/couchdb/issues/4398
+
+$ROOT_DIR = "C:\relax\releases\3.4.2\apache-couchdb-3.4.2-RC1"

Review Comment:
   Okay.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Helper scripts for Windows [couchdb-glazier]

Posted by "big-r81 (via GitHub)" <gi...@apache.org>.
big-r81 commented on code in PR #40:
URL: https://github.com/apache/couchdb-glazier/pull/40#discussion_r1804786713


##########
bin/exclude_tests_win.ps1:
##########
@@ -0,0 +1,34 @@
+# Licensed under the Apache License, Version 2.0 (the "License"); you may not
+# use this file except in compliance with the License. You may obtain a copy of
+# the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations under
+# the License.
+
+
+# Helper script for excluding some tests which fail under Windows
+# see https://github.com/apache/couchdb/issues/4398
+
+$ROOT_DIR = "C:\relax\releases\3.4.2\apache-couchdb-3.4.2-RC1"

Review Comment:
   Yeah maybe, but this is at this stage a manual call of the script, so I would like to leave it as is for the moment ...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Helper scripts for Windows [couchdb-glazier]

Posted by "big-r81 (via GitHub)" <gi...@apache.org>.
big-r81 commented on PR #40:
URL: https://github.com/apache/couchdb-glazier/pull/40#issuecomment-2420274747

   > Do you think it would make sense to mention this tool in the `README` file as well?
   
   Of course, maybe others want to release Windows builds too ;-)! Updated the PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Helper scripts for Windows [couchdb-glazier]

Posted by "big-r81 (via GitHub)" <gi...@apache.org>.
big-r81 commented on code in PR #40:
URL: https://github.com/apache/couchdb-glazier/pull/40#discussion_r1804784498


##########
bin/download_extract_rc.ps1:
##########
@@ -0,0 +1,61 @@
+# Licensed under the Apache License, Version 2.0 (the "License"); you may not
+# use this file except in compliance with the License. You may obtain a copy of
+# the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations under
+# the License.
+
+
+# Helper script for lazy Windows Developers
+# Downloading, checking and extracting the sources of a rc candidate for Windows
+
+$DOWNLOAD_VERSION = "3.4.2"

Review Comment:
   Good point, not my first idea for a first version ;-), but added some parameters!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Helper scripts for Windows [couchdb-glazier]

Posted by "pgj (via GitHub)" <gi...@apache.org>.
pgj commented on code in PR #40:
URL: https://github.com/apache/couchdb-glazier/pull/40#discussion_r1806271178


##########
bin/download_extract_rc.ps1:
##########
@@ -0,0 +1,89 @@
+# Licensed under the Apache License, Version 2.0 (the "License"); you may not
+# use this file except in compliance with the License. You may obtain a copy of
+# the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations under
+# the License.
+
+
+# Helper script for lazy Windows Developers
+# Downloading, checking and extracting the sources of a rc candidate for Windows
+
+<#
+.SYNOPSIS
+    Little helper script for lazy Windows (Release) Developers
+.DESCRIPTION
+    This command downloads, checks and extract a CouchDB source tarball
+
+    -CouchDBVersion         CouchDB version number to download (default 3.4.2)

Review Comment:
   Does it make sense to make it default to any value?  Unless you are planning to keep that default value updated on each new release, it can get more and more misleading as the time goes by.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Helper scripts for Windows [couchdb-glazier]

Posted by "big-r81 (via GitHub)" <gi...@apache.org>.
big-r81 commented on PR #40:
URL: https://github.com/apache/couchdb-glazier/pull/40#issuecomment-2422261852

   Thanks Gábor for your comments and hints (and to force me to do the unpopular tasks as well :stuck_out_tongue_winking_eye:).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Helper scripts for Windows [couchdb-glazier]

Posted by "pgj (via GitHub)" <gi...@apache.org>.
pgj commented on code in PR #40:
URL: https://github.com/apache/couchdb-glazier/pull/40#discussion_r1804612040


##########
bin/download_extract_rc.ps1:
##########
@@ -0,0 +1,61 @@
+# Licensed under the Apache License, Version 2.0 (the "License"); you may not
+# use this file except in compliance with the License. You may obtain a copy of
+# the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations under
+# the License.
+
+
+# Helper script for lazy Windows Developers
+# Downloading, checking and extracting the sources of a rc candidate for Windows
+
+$DOWNLOAD_VERSION = "3.4.2"

Review Comment:
   Are these variables meant to be parametric?  It would be nice if the script could take them as external parameters.



##########
bin/exclude_tests_win.ps1:
##########
@@ -0,0 +1,34 @@
+# Licensed under the Apache License, Version 2.0 (the "License"); you may not
+# use this file except in compliance with the License. You may obtain a copy of
+# the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations under
+# the License.
+
+
+# Helper script for excluding some tests which fail under Windows
+# see https://github.com/apache/couchdb/issues/4398
+
+$ROOT_DIR = "C:\relax\releases\3.4.2\apache-couchdb-3.4.2-RC1"

Review Comment:
   It might make sense to introduce variable to capture the version number which could be then passed as a parameter externally.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Helper scripts for Windows [couchdb-glazier]

Posted by "big-r81 (via GitHub)" <gi...@apache.org>.
big-r81 commented on code in PR #40:
URL: https://github.com/apache/couchdb-glazier/pull/40#discussion_r1804784498


##########
bin/download_extract_rc.ps1:
##########
@@ -0,0 +1,61 @@
+# Licensed under the Apache License, Version 2.0 (the "License"); you may not
+# use this file except in compliance with the License. You may obtain a copy of
+# the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations under
+# the License.
+
+
+# Helper script for lazy Windows Developers
+# Downloading, checking and extracting the sources of a rc candidate for Windows
+
+$DOWNLOAD_VERSION = "3.4.2"

Review Comment:
   Good point, not my first idea for an initial version ;-), but added some parameters!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Helper scripts for Windows [couchdb-glazier]

Posted by "big-r81 (via GitHub)" <gi...@apache.org>.
big-r81 merged PR #40:
URL: https://github.com/apache/couchdb-glazier/pull/40


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org