You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by ja...@apache.org on 2025/06/23 16:48:58 UTC
(pinot) branch master updated: Fixes realtimeBytesConsumed metric and jmx export rule (#16158)
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new ceadd35bb1 Fixes realtimeBytesConsumed metric and jmx export rule (#16158)
ceadd35bb1 is described below
commit ceadd35bb105287ac3b9a83575e2494bd820078c
Author: NOOB <43...@users.noreply.github.com>
AuthorDate: Mon Jun 23 22:18:52 2025 +0530
Fixes realtimeBytesConsumed metric and jmx export rule (#16158)
---
.../images/pinot/etc/jmx_prometheus_javaagent/configs/pinot.yml | 2 +-
.../core/data/manager/realtime/RealtimeSegmentDataManager.java | 9 ++++++---
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/docker/images/pinot/etc/jmx_prometheus_javaagent/configs/pinot.yml b/docker/images/pinot/etc/jmx_prometheus_javaagent/configs/pinot.yml
index dd25f3719c..9847c2b6b2 100644
--- a/docker/images/pinot/etc/jmx_prometheus_javaagent/configs/pinot.yml
+++ b/docker/images/pinot/etc/jmx_prometheus_javaagent/configs/pinot.yml
@@ -448,7 +448,7 @@ rules:
database: "$2"
table: "$1$3"
tableType: "$4"
-- pattern: "\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"ServerMetrics\", name=\"pinot\\.server\\.(([^.]+)\\.)?([^.]*)_(OFFLINE|REALTIME)\\-(.+)\\-(\\w+)\\.(invalidRealtimeRowsDropped|incompleteRealtimeRowsConsumed|rowsWithErrors|realtimeRowsConsumed|realtimeRowsFetched|streamConsumerCreateExceptions)\"><>(\\w+)"
+- pattern: "\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"ServerMetrics\", name=\"pinot\\.server\\.(([^.]+)\\.)?([^.]*)_(OFFLINE|REALTIME)\\-(.+)\\-(\\w+)\\.(invalidRealtimeRowsDropped|incompleteRealtimeRowsConsumed|rowsWithErrors|realtimeRowsConsumed|realtimeRowsFetched|realtimeBytesConsumed|streamConsumerCreateExceptions)\"><>(\\w+)"
name: "pinot_server_$7_$8"
cache: true
labels:
diff --git a/pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java b/pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java
index 3e3dd8f01b..beea808a66 100644
--- a/pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java
+++ b/pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java
@@ -684,9 +684,12 @@ public class RealtimeSegmentDataManager extends SegmentDataManager {
_serverMetrics.addMeteredGlobalValue(ServerMeter.REALTIME_ROWS_CONSUMED, 1L);
int recordSerializedValueLength = _lastRowMetadata.getRecordSerializedSize();
- realtimeBytesIngestedMeter =
- _serverMetrics.addMeteredTableValue(_clientId, ServerMeter.REALTIME_BYTES_CONSUMED,
- recordSerializedValueLength, realtimeBytesIngestedMeter);
+ if (recordSerializedValueLength > 0) {
+ realtimeBytesIngestedMeter =
+ _serverMetrics.addMeteredTableValue(_clientId, ServerMeter.REALTIME_BYTES_CONSUMED,
+ recordSerializedValueLength, realtimeBytesIngestedMeter);
+ _serverMetrics.addMeteredGlobalValue(ServerMeter.REALTIME_BYTES_CONSUMED, recordSerializedValueLength);
+ }
} catch (Exception e) {
_numRowsErrored++;
_numBytesDropped += rowSizeInBytes;
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org