You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by mgaido91 <gi...@git.apache.org> on 2017/12/15 11:15:06 UTC
[GitHub] nifi pull request #2344: NIFI-4619: Enable expression language on AWSCredent...
GitHub user mgaido91 opened a pull request:
https://github.com/apache/nifi/pull/2344
NIFI-4619: Enable expression language on AWSCredentialsProviderControllerService properties
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? N/A
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? N/A
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? N/A
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? N/A
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered? N/A
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mgaido91/nifi NIFI-4619
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2344.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2344
----
commit 1888a1b83bd1813d296ae3fd2c789b86b973385e
Author: Marco Gaido <mg...@hortonworks.com>
Date: 2017-12-15T10:06:13Z
NIFI-4619: Enable expression language on AWSCredentialsProviderControllerService properties
----
---
[GitHub] nifi issue #2344: NIFI-4619: Enable EL on AWSCredentialsProviderControllerSe...
Posted by jvwing <gi...@git.apache.org>.
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/2344
Thanks, @mgaido91! The code change looks good and works good. And thanks for tuning up the tests appropriately.
---
[GitHub] nifi issue #2344: NIFI-4619: Enable expression language on AWSCredentialsPro...
Posted by mgaido91 <gi...@git.apache.org>.
Github user mgaido91 commented on the issue:
https://github.com/apache/nifi/pull/2344
@jvwing @mans2singh may I kindly ask you some help reviewing this? I saw you are the last contributors on it... Thanks!
---
[GitHub] nifi issue #2344: NIFI-4619: Enable EL on AWSCredentialsProviderControllerSe...
Posted by jvwing <gi...@git.apache.org>.
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/2344
Reviewing...
---
[GitHub] nifi issue #2344: NIFI-4619: Enable EL on AWSCredentialsProviderControllerSe...
Posted by mgaido91 <gi...@git.apache.org>.
Github user mgaido91 commented on the issue:
https://github.com/apache/nifi/pull/2344
thank you for your review @jvwing!
---
[GitHub] nifi pull request #2344: NIFI-4619: Enable EL on AWSCredentialsProviderContr...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2344
---