[GitHub] [guacamole-client] mike-jumper commented on a diff in pull request #673: GUACAMOLE-1479: Change the style of disabled users/groups.

[GitBox <gi...@apache.org>]

mike-jumper commented on code in PR #673:
URL: https://github.com/apache/guacamole-client/pull/673#discussion_r1045297823


##########
guacamole/src/main/frontend/src/app/settings/templates/settingsUsers.html:
##########
@@ -43,7 +43,7 @@
                 <td class="username">
                     <a ng-href="#/manage/{{manageableUser.dataSource | escape}}/users/{{manageableUser.user.username | escape}}">
                         <div class="icon user"></div>
-                        <span class="name">{{manageableUser.user.username}}</span>
+                        <span class="name" ng-class="{'user-disabled' : (manageableUser.user.attributes['disabled'] !== null && manageableUser.user.attributes['disabled'] === 'true')}">{{manageableUser.user.username}}</span>

Review Comment:
   Same here - the logic behind this test should be encapsulated within the controller.



##########
guacamole/src/main/frontend/src/app/settings/templates/settingsUserGroups.html:
##########
@@ -34,7 +34,7 @@
                 <td class="user-group-name">
                     <a ng-href="#/manage/{{manageableUserGroup.dataSource | escape}}/userGroups/{{manageableUserGroup.userGroup.identifier | escape}}">
                         <div class="icon user-group"></div>
-                        <span class="name">{{manageableUserGroup.userGroup.identifier}}</span>
+                        <span class="name" ng-class="{'user-group-disabled' : (manageableUserGroup.userGroup.attributes['disabled'] !== null && manageableUserGroup.userGroup.attributes['disabled'] === 'true')}">{{manageableUserGroup.userGroup.identifier}}</span>

Review Comment:
   This level of logic should be abstracted away within the controller.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org