You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by heary-cao <gi...@git.apache.org> on 2018/02/02 02:47:49 UTC
[GitHub] spark pull request #20482: [SPARK-23311][SQL][TEST]add FilterFunction test c...
GitHub user heary-cao opened a pull request:
https://github.com/apache/spark/pull/20482
[SPARK-23311][SQL][TEST]add FilterFunction test case for test CombineTypedFilters
## What changes were proposed in this pull request?
In the current test case for CombineTypedFilters, we lack the test of FilterFunction, so let's add it.
In addition, in TypedFilterOptimizationSuite's existing test cases, Let's extract a common LocalRelation.
## How was this patch tested?
add new test cases.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/heary-cao/spark TypedFilterOptimizationSuite
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20482.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20482
----
commit 424bdc301c8cea9802465ff7a12ab80ecba6ed08
Author: caoxuewen <ca...@...>
Date: 2018-02-02T02:33:49Z
add FilterFunction test case for test CombineTypedFilters
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20482: [SPARK-23311][SQL][TEST]add FilterFunction test case for...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20482
**[Test build #87023 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87023/testReport)** for PR 20482 at commit [`6042523`](https://github.com/apache/spark/commit/6042523d54dbebceb80ebd4b180bd9b73c5bd3ed).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20482: [SPARK-23311][SQL][TEST]add FilterFunction test case for...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20482
retest this please
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20482: [SPARK-23311][SQL][TEST]add FilterFunction test c...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20482
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20482: [SPARK-23311][SQL][TEST]add FilterFunction test case for...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20482
**[Test build #87023 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87023/testReport)** for PR 20482 at commit [`6042523`](https://github.com/apache/spark/commit/6042523d54dbebceb80ebd4b180bd9b73c5bd3ed).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20482: [SPARK-23311][SQL][TEST]add FilterFunction test case for...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20482
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20482: [SPARK-23311][SQL][TEST]add FilterFunction test case for...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20482
Thanks! Merged to master/2.3
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20482: [SPARK-23311][SQL][TEST]add FilterFunction test case for...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20482
**[Test build #86964 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86964/testReport)** for PR 20482 at commit [`f45ef79`](https://github.com/apache/spark/commit/f45ef79ff69e145b4fe825504d6abb7f76aa921b).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20482: [SPARK-23311][SQL][TEST]add FilterFunction test case for...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20482
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87021/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20482: [SPARK-23311][SQL][TEST]add FilterFunction test case for...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20482
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20482: [SPARK-23311][SQL][TEST]add FilterFunction test case for...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20482
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20482: [SPARK-23311][SQL][TEST]add FilterFunction test case for...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20482
**[Test build #87021 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87021/testReport)** for PR 20482 at commit [`6042523`](https://github.com/apache/spark/commit/6042523d54dbebceb80ebd4b180bd9b73c5bd3ed).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20482: [SPARK-23311][SQL][TEST]add FilterFunction test case for...
Posted by heary-cao <gi...@git.apache.org>.
Github user heary-cao commented on the issue:
https://github.com/apache/spark/pull/20482
@cloud-fan @gatorsmile Can you help me to review it. thanks.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20482: [SPARK-23311][SQL][TEST]add FilterFunction test case for...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20482
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20482: [SPARK-23311][SQL][TEST]add FilterFunction test case for...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20482
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87023/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20482: [SPARK-23311][SQL][TEST]add FilterFunction test case for...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20482
**[Test build #87021 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87021/testReport)** for PR 20482 at commit [`6042523`](https://github.com/apache/spark/commit/6042523d54dbebceb80ebd4b180bd9b73c5bd3ed).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20482: [SPARK-23311][SQL][TEST]add FilterFunction test case for...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20482
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20482: [SPARK-23311][SQL][TEST]add FilterFunction test case for...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20482
**[Test build #86964 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86964/testReport)** for PR 20482 at commit [`f45ef79`](https://github.com/apache/spark/commit/f45ef79ff69e145b4fe825504d6abb7f76aa921b).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20482: [SPARK-23311][SQL][TEST]add FilterFunction test case for...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20482
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86964/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20482: [SPARK-23311][SQL][TEST]add FilterFunction test case for...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20482
ok to test
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org