You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "zhouyuan (via GitHub)" <gi...@apache.org> on 2024/11/26 08:52:59 UTC
[PR] [GLUTEN-8046][VL] CI: fix velox cache/bundle package script [incubator-gluten]
zhouyuan opened a new pull request, #8051:
URL: https://github.com/apache/incubator-gluten/pull/8051
## What changes were proposed in this pull request?
This patch fixes the cache/build script due to nodejs version update in GHA
fixes #8046
## How was this patch tested?
pass GHA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-8046][VL] CI: fix velox cache/bundle package script [incubator-gluten]
Posted by "zhztheplayer (via GitHub)" <gi...@apache.org>.
zhztheplayer commented on code in PR #8051:
URL: https://github.com/apache/incubator-gluten/pull/8051#discussion_r1859516551
##########
.github/workflows/velox_backend.yml:
##########
@@ -962,12 +1024,12 @@ jobs:
df -a
bash dev/ci-velox-buildshared-centos-8.sh
ccache -s
- - name: "Save ccache"
- uses: actions/cache/save@v3
- id: ccache
- with:
- path: '${{ env.CCACHE_DIR }}'
- key: ccache-centos8-release-default-${{github.sha}}
+ # - name: "Save ccache"
+ # uses: actions/cache/save@v3
+ # id: ccache
+ # with:
+ # path: '${{ env.CCACHE_DIR }}'
+ # key: ccache-centos8-release-default-${{github.sha}}
Review Comment:
is this intentional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-8046][VL] CI: fix velox cache/bundle package script [incubator-gluten]
Posted by "zhouyuan (via GitHub)" <gi...@apache.org>.
zhouyuan commented on code in PR #8051:
URL: https://github.com/apache/incubator-gluten/pull/8051#discussion_r1859528332
##########
.github/workflows/velox_backend.yml:
##########
@@ -962,12 +1024,12 @@ jobs:
df -a
bash dev/ci-velox-buildshared-centos-8.sh
ccache -s
- - name: "Save ccache"
- uses: actions/cache/save@v3
- id: ccache
- with:
- path: '${{ env.CCACHE_DIR }}'
- key: ccache-centos8-release-default-${{github.sha}}
+ # - name: "Save ccache"
+ # uses: actions/cache/save@v3
+ # id: ccache
+ # with:
+ # path: '${{ env.CCACHE_DIR }}'
+ # key: ccache-centos8-release-default-${{github.sha}}
Review Comment:
Yes, this is intended to disable the centos8 ccache from PR so the main branch can have more cache, as there's only 10G for each project
https://github.com/apache/incubator-gluten/actions/caches
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-8046][VL] CI: fix velox cache/bundle package script [incubator-gluten]
Posted by "zhouyuan (via GitHub)" <gi...@apache.org>.
zhouyuan merged PR #8051:
URL: https://github.com/apache/incubator-gluten/pull/8051
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-8046][VL] CI: fix velox cache/bundle package script [incubator-gluten]
Posted by "zhouyuan (via GitHub)" <gi...@apache.org>.
zhouyuan commented on PR #8051:
URL: https://github.com/apache/incubator-gluten/pull/8051#issuecomment-2502414831
@zhztheplayer thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-8046][VL] CI: fix velox cache/bundle package script [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8051:
URL: https://github.com/apache/incubator-gluten/pull/8051#issuecomment-2500027166
https://github.com/apache/incubator-gluten/issues/8046
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org