You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/04/06 09:57:16 UTC

[GitHub] [apisix] kwanhur commented on a diff in pull request #6750: feat(response-rewrite): support filters

kwanhur commented on code in PR #6750:
URL: https://github.com/apache/apisix/pull/6750#discussion_r843742606


##########
apisix/plugins/response-rewrite.lua:
##########
@@ -115,6 +152,23 @@ function _M.check_schema(conf)
         end
     end
 
+    if conf.filters then
+        for _, filter in ipairs(conf.filters) do
+            for field, value in pairs(filter) do

Review Comment:
   Ok, did `required = {"regex", "replace"}`. Fields `scope` and `options` have default value, so not in `required`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org