(cloudberry) 05/13: Cleanup a FIXME in ATExecAddIndex

[ma...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

maxyang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudberry.git

commit eac1b11d50cb8fd50b7d7388d45749bb5c559e9f
Author: Huansong Fu <fu...@gmail.com>
AuthorDate: Tue Aug 30 11:59:00 2022 -0700

    Cleanup a FIXME in ATExecAddIndex
    
    We used to always dispatch in DefineIndex() but now we do not if
    it is part of the ALTER TABLE command execution. So we no longer
    need to skip DefineIndex for QEs. Confirmed and remove this FIXME.
---
 src/backend/commands/tablecmds.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
index 822da63c30..36caa4753b 100644
--- a/src/backend/commands/tablecmds.c
+++ b/src/backend/commands/tablecmds.c
@@ -10371,13 +10371,6 @@ ATExecAddIndex(AlteredTableInfo *tab, Relation rel,
 	/* The IndexStmt has already been through transformIndexStmt */
 	Assert(stmt->transformed);
 
-	/* The index should already be built if we are a QE */
-	/* GPDB_12_MERGE_FIXME: it doesn't seem to work that way anymore. */
-#if 0
-	if (Gp_role == GP_ROLE_EXECUTE)
-		return InvalidObjectAddress;
-#endif
-
 	/* suppress schema rights check when rebuilding existing index */
 	check_rights = !is_rebuild;
 	/* skip index build if phase 3 will do it or we're reusing an old one */


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org