You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by combineads <gi...@git.apache.org> on 2016/09/23 06:41:44 UTC
[GitHub] nifi pull request #1053: NIFI-2811 JdbcCommon doesn't convert bigint(20) col...
GitHub user combineads opened a pull request:
https://github.com/apache/nifi/pull/1053
NIFI-2811 JdbcCommon doesn't convert bigint(20) column.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/combineads/nifi NIFI-2811
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1053.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1053
----
commit d27e5380ed490ee1aecd27a487b32b36e80c2594
Author: Byunghwa Yun <co...@combineads.co.kr>
Date: 2016-09-23T00:21:21Z
NIFI-2803 The pagination of GenerateTableFetch has a sort bug.
commit 7643fa1dbba85fcb16a1d0a8474a33fa0c0ddce4
Author: Byunghwa Yun <co...@combineads.co.kr>
Date: 2016-09-23T06:34:49Z
NIFI-2811 JdbcCommon doesn't convert bigint(20) column.
commit 0275a8da0cb474124d3327ad62a918e7032f4ba7
Author: Byunghwa Yun <co...@combineads.co.kr>
Date: 2016-09-23T06:38:21Z
rebase master.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1053: NIFI-2811 JdbcCommon doesn't convert bigint(20) column.
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/1053
+1 Looks good to me, thank you for the fix! It's been very frustrating trying to find out how each database handles various types, some return a different JDBC type than the corresponding Java type, and some even differ from each other if the underlying data type is signed or unsigned (which is what happened in this case, the unsigned path was fixed in NIFI-2531 (#823) but the signed path was not).
Tested with various bigint fields in different databases, signed bigint fields with small values (represented in MySQL as java Longs) are processed correctly. Merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1053: NIFI-2811 JdbcCommon doesn't convert bigint(20) col...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/1053
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1053: NIFI-2811 JdbcCommon doesn't convert bigint(20) column.
Posted by combineads <gi...@git.apache.org>.
Github user combineads commented on the issue:
https://github.com/apache/nifi/pull/1053
Hello. @mattyb149.
Could you review this PR?
Actually, we have this problem.
My System has bigint(20) type column in MySql with some small value. e.i. 936398
At the time NiFi throws below an exception.
Caused by: org.apache.avro.file.DataFileWriter$AppendWriteException: org.apache.avro.UnresolvedUnionException: Not in union ["null","string"]: 936398
Please, review this. We operate own NiFi branch because this issue doesn't merge master branch.
I hope to use NiFi master branch one day soon.
Thank you for your effort.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1053: NIFI-2811 JdbcCommon doesn't convert bigint(20) column.
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/1053
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---