You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/10/06 12:50:24 UTC
[GitHub] [submarine] woodcutter-eric opened a new pull request #766: Submarine 1046 Remove package-lock.json in website
woodcutter-eric opened a new pull request #766:
URL: https://github.com/apache/submarine/pull/766
### What is this PR for?
This PR remove the package-lock.json under the website/ directory and add it to .gitignore. It also remove checking condition in deploy_website.yml for package-lock.json
### What type of PR is it?
[Improvement]
### Todos
* [x] - Remove package-lock.json
* [x] - Add package-lock.json to .gitignore
* [x] - Remove checking condition for package-lock.json in deploy_website.yml for package-lock.json
### What is the Jira issue?
<!-- * Open an issue on Jira https://issues.apache.org/jira/browse/SUBMARINE/
* Put link here, and add [SUBMARINE-*Jira number*] in PR title, eg. `SUBMARINE-23. PR title`
-->
https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-1046
### How should this be tested?
<!--
* First time? Setup Travis CI as described on https://submarine.apache.org/contribution/contributions.html#continuous-integration
* Strongly recommended: add automated unit tests for any new or changed behavior
* Outline any manual steps to test the PR here.
-->
### Screenshots (if appropriate)
### Questions:
* Do the license files need updating? No
* Are there breaking changes for older versions? No
* Does this need new documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] MortalHappiness commented on pull request #766: SUBMARINE-1046. Remove package-lock.json in website
Posted by GitBox <gi...@apache.org>.
MortalHappiness commented on pull request #766:
URL: https://github.com/apache/submarine/pull/766#issuecomment-936341676
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] asfgit closed pull request #766: SUBMARINE-1046. Remove package-lock.json in website
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #766:
URL: https://github.com/apache/submarine/pull/766
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] MortalHappiness commented on pull request #766: Submarine 1046 Remove package-lock.json in website
Posted by GitBox <gi...@apache.org>.
MortalHappiness commented on pull request #766:
URL: https://github.com/apache/submarine/pull/766#issuecomment-936283871
@woodcutter-eric Thank you for your contribution. The PR title should be "SUBMARINE-1046. Remove package-lock.json in website". Please change it, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] woodcutter-eric commented on pull request #766: SUBMARINE-1046. Remove package-lock.json in website.
Posted by GitBox <gi...@apache.org>.
woodcutter-eric commented on pull request #766:
URL: https://github.com/apache/submarine/pull/766#issuecomment-936312800
@MortalHappiness I follow your recommendation. Please check again. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] woodcutter-eric commented on pull request #766: Submarine 1046 Remove package-lock.json in website
Posted by GitBox <gi...@apache.org>.
woodcutter-eric commented on pull request #766:
URL: https://github.com/apache/submarine/pull/766#issuecomment-936176126
@MortalHappiness Can you help review for me? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] MortalHappiness commented on a change in pull request #766: Submarine 1046 Remove package-lock.json in website
Posted by GitBox <gi...@apache.org>.
MortalHappiness commented on a change in pull request #766:
URL: https://github.com/apache/submarine/pull/766#discussion_r723306531
##########
File path: .github/workflows/deploy_website.yml
##########
@@ -66,10 +64,8 @@ jobs:
run: |
git config --global user.email "pingsutw@apache.org"
git config --global user.name "pingsutw"
- if [ -e yarn.lock ]; then
+ if [[ -e yarn.lock ]]; then
yarn install --frozen-lockfile
- elif [ -e package-lock.json ]; then
- npm ci
else
npm i
fi
Review comment:
These lines should be changed to `run: yarn install --frozen-lockfile`.
##########
File path: .github/workflows/deploy_website.yml
##########
@@ -33,10 +33,8 @@ jobs:
- name: Test Build
working-directory: ./website
run: |
- if [ -e yarn.lock ]; then
+ if [[ -e yarn.lock ]]; then
yarn install --frozen-lockfile
- elif [ -e package-lock.json ]; then
- npm ci
else
npm i
fi
Review comment:
These lines should be changed to `run: yarn install --frozen-lockfile`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org