You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Esteve Fernandez (JIRA)" <ji...@apache.org> on 2009/02/09 14:52:59 UTC
[jira] Created: (THRIFT-325) Phase out deprecated CLI compiler
options in favour of --gen STR
Phase out deprecated CLI compiler options in favour of --gen STR
----------------------------------------------------------------
Key: THRIFT-325
URL: https://issues.apache.org/jira/browse/THRIFT-325
Project: Thrift
Issue Type: Improvement
Reporter: Esteve Fernandez
Generators for PHP, Erlang and XSD still use language-specific CLI options (-php*, -erl, -xsd). They should use the new --gen STR syntax instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-325) Phase out deprecated CLI compiler
options in favour of --gen STR
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Esteve Fernandez updated THRIFT-325:
------------------------------------
Component/s: Compiler (PHP)
Compiler (Erlang)
> Phase out deprecated CLI compiler options in favour of --gen STR
> ----------------------------------------------------------------
>
> Key: THRIFT-325
> URL: https://issues.apache.org/jira/browse/THRIFT-325
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Erlang), Compiler (PHP)
> Reporter: Esteve Fernandez
>
> Generators for PHP, Erlang and XSD still use language-specific CLI options (-php*, -erl, -xsd). They should use the new --gen STR syntax instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-325) Phase out deprecated CLI compiler
options in favour of --gen STR
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672522#action_12672522 ]
David Reiss commented on THRIFT-325:
------------------------------------
I tried to keep the format as similar as possible to the first round of these changes. Unless there are objections, I'll commit tomorrow.
> Phase out deprecated CLI compiler options in favour of --gen STR
> ----------------------------------------------------------------
>
> Key: THRIFT-325
> URL: https://issues.apache.org/jira/browse/THRIFT-325
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Erlang), Compiler (General), Compiler (PHP)
> Reporter: Esteve Fernandez
> Attachments: 0001-THRIFT-325.-Include-t_generator.h-in-main.cc.patch, 0002-Make-the-Erlang-generator-dynamic.patch, 0003-Remove-t_erl_generator.h.patch, 0004-Allow-the-Thrift-compiler-to-be-built-without-the-Er.patch, 0005-Make-the-XSD-generator-dynamic.patch, 0006-Remove-t_xsd_generator.h.patch, 0007-Allow-the-Thrift-compiler-to-be-built-without-the-XS.patch, 0008-Make-the-XSD-generator-use-non-hardcoded-namespaces.patch, 0009-Make-the-PHP-generator-dynamic.patch, 0010-Remove-t_php_generator.h.patch, 0011-Allow-the-Thrift-compiler-to-be-built-without-the-PH.patch, 0012-Make-the-PHP-generator-use-non-hardcoded-namespaces.patch, 0013-THRIFT-325.-Remove-a-bunch-of-uses-of-the-old-comman.patch, thrift-325.patch
>
>
> Generators for PHP, Erlang and XSD still use language-specific CLI options (-php*, -erl, -xsd). They should use the new --gen STR syntax instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-325) Phase out deprecated CLI compiler
options in favour of --gen STR
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss resolved THRIFT-325.
--------------------------------
Resolution: Fixed
> Phase out deprecated CLI compiler options in favour of --gen STR
> ----------------------------------------------------------------
>
> Key: THRIFT-325
> URL: https://issues.apache.org/jira/browse/THRIFT-325
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Erlang), Compiler (General), Compiler (PHP)
> Reporter: Esteve Fernandez
> Attachments: 0001-THRIFT-325.-Include-t_generator.h-in-main.cc.patch, 0002-Make-the-Erlang-generator-dynamic.patch, 0003-Remove-t_erl_generator.h.patch, 0004-Allow-the-Thrift-compiler-to-be-built-without-the-Er.patch, 0005-Make-the-XSD-generator-dynamic.patch, 0006-Remove-t_xsd_generator.h.patch, 0007-Allow-the-Thrift-compiler-to-be-built-without-the-XS.patch, 0008-Make-the-XSD-generator-use-non-hardcoded-namespaces.patch, 0009-Make-the-PHP-generator-dynamic.patch, 0010-Remove-t_php_generator.h.patch, 0011-Allow-the-Thrift-compiler-to-be-built-without-the-PH.patch, 0012-Make-the-PHP-generator-use-non-hardcoded-namespaces.patch, 0013-THRIFT-325.-Remove-a-bunch-of-uses-of-the-old-comman.patch, extra_diffs.patch, thrift-325.patch
>
>
> Generators for PHP, Erlang and XSD still use language-specific CLI options (-php*, -erl, -xsd). They should use the new --gen STR syntax instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-325) Phase out deprecated CLI compiler
options in favour of --gen STR
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672557#action_12672557 ]
Esteve Fernandez commented on THRIFT-325:
-----------------------------------------
I think it would be better to file a separate issue for 0004, 0007, 0008, it would make it easier to track revisions and issues. Anyway, they look fine.
BTW, I had a quick look at the rest of the patches and they seem to already include the changes that were in thrift-325.patch. Is there anything I overlooked?
> Phase out deprecated CLI compiler options in favour of --gen STR
> ----------------------------------------------------------------
>
> Key: THRIFT-325
> URL: https://issues.apache.org/jira/browse/THRIFT-325
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Erlang), Compiler (General), Compiler (PHP)
> Reporter: Esteve Fernandez
> Attachments: 0001-THRIFT-325.-Include-t_generator.h-in-main.cc.patch, 0002-Make-the-Erlang-generator-dynamic.patch, 0003-Remove-t_erl_generator.h.patch, 0004-Allow-the-Thrift-compiler-to-be-built-without-the-Er.patch, 0005-Make-the-XSD-generator-dynamic.patch, 0006-Remove-t_xsd_generator.h.patch, 0007-Allow-the-Thrift-compiler-to-be-built-without-the-XS.patch, 0008-Make-the-XSD-generator-use-non-hardcoded-namespaces.patch, 0009-Make-the-PHP-generator-dynamic.patch, 0010-Remove-t_php_generator.h.patch, 0011-Allow-the-Thrift-compiler-to-be-built-without-the-PH.patch, 0012-Make-the-PHP-generator-use-non-hardcoded-namespaces.patch, 0013-THRIFT-325.-Remove-a-bunch-of-uses-of-the-old-comman.patch, thrift-325.patch
>
>
> Generators for PHP, Erlang and XSD still use language-specific CLI options (-php*, -erl, -xsd). They should use the new --gen STR syntax instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-325) Phase out deprecated CLI compiler
options in favour of --gen STR
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672191#action_12672191 ]
David Reiss commented on THRIFT-325:
------------------------------------
I'm working on a slightly more complete version of these patches (removing header files entirely, etc.). Should be ready tomorrow.
> Phase out deprecated CLI compiler options in favour of --gen STR
> ----------------------------------------------------------------
>
> Key: THRIFT-325
> URL: https://issues.apache.org/jira/browse/THRIFT-325
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Erlang), Compiler (General), Compiler (PHP)
> Reporter: Esteve Fernandez
>
> Generators for PHP, Erlang and XSD still use language-specific CLI options (-php*, -erl, -xsd). They should use the new --gen STR syntax instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-325) Phase out deprecated CLI compiler
options in favour of --gen STR
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss updated THRIFT-325:
-------------------------------
Attachment: 0013-THRIFT-325.-Remove-a-bunch-of-uses-of-the-old-comman.patch
0012-Make-the-PHP-generator-use-non-hardcoded-namespaces.patch
0011-Allow-the-Thrift-compiler-to-be-built-without-the-PH.patch
0010-Remove-t_php_generator.h.patch
0009-Make-the-PHP-generator-dynamic.patch
0008-Make-the-XSD-generator-use-non-hardcoded-namespaces.patch
0007-Allow-the-Thrift-compiler-to-be-built-without-the-XS.patch
0006-Remove-t_xsd_generator.h.patch
0005-Make-the-XSD-generator-dynamic.patch
0004-Allow-the-Thrift-compiler-to-be-built-without-the-Er.patch
0003-Remove-t_erl_generator.h.patch
0002-Make-the-Erlang-generator-dynamic.patch
0001-THRIFT-325.-Include-t_generator.h-in-main.cc.patch
> Phase out deprecated CLI compiler options in favour of --gen STR
> ----------------------------------------------------------------
>
> Key: THRIFT-325
> URL: https://issues.apache.org/jira/browse/THRIFT-325
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Erlang), Compiler (General), Compiler (PHP)
> Reporter: Esteve Fernandez
> Attachments: 0001-THRIFT-325.-Include-t_generator.h-in-main.cc.patch, 0002-Make-the-Erlang-generator-dynamic.patch, 0003-Remove-t_erl_generator.h.patch, 0004-Allow-the-Thrift-compiler-to-be-built-without-the-Er.patch, 0005-Make-the-XSD-generator-dynamic.patch, 0006-Remove-t_xsd_generator.h.patch, 0007-Allow-the-Thrift-compiler-to-be-built-without-the-XS.patch, 0008-Make-the-XSD-generator-use-non-hardcoded-namespaces.patch, 0009-Make-the-PHP-generator-dynamic.patch, 0010-Remove-t_php_generator.h.patch, 0011-Allow-the-Thrift-compiler-to-be-built-without-the-PH.patch, 0012-Make-the-PHP-generator-use-non-hardcoded-namespaces.patch, 0013-THRIFT-325.-Remove-a-bunch-of-uses-of-the-old-comman.patch, thrift-325.patch
>
>
> Generators for PHP, Erlang and XSD still use language-specific CLI options (-php*, -erl, -xsd). They should use the new --gen STR syntax instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-325) Phase out deprecated CLI compiler
options in favour of --gen STR
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Esteve Fernandez updated THRIFT-325:
------------------------------------
Component/s: Compiler (General)
> Phase out deprecated CLI compiler options in favour of --gen STR
> ----------------------------------------------------------------
>
> Key: THRIFT-325
> URL: https://issues.apache.org/jira/browse/THRIFT-325
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Erlang), Compiler (General), Compiler (PHP)
> Reporter: Esteve Fernandez
>
> Generators for PHP, Erlang and XSD still use language-specific CLI options (-php*, -erl, -xsd). They should use the new --gen STR syntax instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-325) Phase out deprecated CLI compiler
options in favour of --gen STR
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674347#action_12674347 ]
David Reiss commented on THRIFT-325:
------------------------------------
I'm not sure what is special about 4, 7, and 8 that would warrant an extra issue. I'm attaching an incremental diff from your version to mine that shows the extra stuff that I did.
> Phase out deprecated CLI compiler options in favour of --gen STR
> ----------------------------------------------------------------
>
> Key: THRIFT-325
> URL: https://issues.apache.org/jira/browse/THRIFT-325
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Erlang), Compiler (General), Compiler (PHP)
> Reporter: Esteve Fernandez
> Attachments: 0001-THRIFT-325.-Include-t_generator.h-in-main.cc.patch, 0002-Make-the-Erlang-generator-dynamic.patch, 0003-Remove-t_erl_generator.h.patch, 0004-Allow-the-Thrift-compiler-to-be-built-without-the-Er.patch, 0005-Make-the-XSD-generator-dynamic.patch, 0006-Remove-t_xsd_generator.h.patch, 0007-Allow-the-Thrift-compiler-to-be-built-without-the-XS.patch, 0008-Make-the-XSD-generator-use-non-hardcoded-namespaces.patch, 0009-Make-the-PHP-generator-dynamic.patch, 0010-Remove-t_php_generator.h.patch, 0011-Allow-the-Thrift-compiler-to-be-built-without-the-PH.patch, 0012-Make-the-PHP-generator-use-non-hardcoded-namespaces.patch, 0013-THRIFT-325.-Remove-a-bunch-of-uses-of-the-old-comman.patch, extra_diffs.patch, thrift-325.patch
>
>
> Generators for PHP, Erlang and XSD still use language-specific CLI options (-php*, -erl, -xsd). They should use the new --gen STR syntax instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-325) Phase out deprecated CLI compiler
options in favour of --gen STR
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Esteve Fernandez updated THRIFT-325:
------------------------------------
Attachment: thrift-325.patch
Combined patch (THRIFT-326, THRIFT-327, THRIFT-328)
> Phase out deprecated CLI compiler options in favour of --gen STR
> ----------------------------------------------------------------
>
> Key: THRIFT-325
> URL: https://issues.apache.org/jira/browse/THRIFT-325
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Erlang), Compiler (General), Compiler (PHP)
> Reporter: Esteve Fernandez
> Attachments: thrift-325.patch
>
>
> Generators for PHP, Erlang and XSD still use language-specific CLI options (-php*, -erl, -xsd). They should use the new --gen STR syntax instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-325) Phase out deprecated CLI compiler
options in favour of --gen STR
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672210#action_12672210 ]
Esteve Fernandez commented on THRIFT-325:
-----------------------------------------
Great. Anyway, I combined all three patches into one, making all three generators more uniform, removing the header files, cleaning up main.cc, etc.
> Phase out deprecated CLI compiler options in favour of --gen STR
> ----------------------------------------------------------------
>
> Key: THRIFT-325
> URL: https://issues.apache.org/jira/browse/THRIFT-325
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Erlang), Compiler (General), Compiler (PHP)
> Reporter: Esteve Fernandez
> Attachments: thrift-325.patch
>
>
> Generators for PHP, Erlang and XSD still use language-specific CLI options (-php*, -erl, -xsd). They should use the new --gen STR syntax instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-325) Phase out deprecated CLI compiler
options in favour of --gen STR
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss updated THRIFT-325:
-------------------------------
Attachment: extra_diffs.patch
> Phase out deprecated CLI compiler options in favour of --gen STR
> ----------------------------------------------------------------
>
> Key: THRIFT-325
> URL: https://issues.apache.org/jira/browse/THRIFT-325
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Erlang), Compiler (General), Compiler (PHP)
> Reporter: Esteve Fernandez
> Attachments: 0001-THRIFT-325.-Include-t_generator.h-in-main.cc.patch, 0002-Make-the-Erlang-generator-dynamic.patch, 0003-Remove-t_erl_generator.h.patch, 0004-Allow-the-Thrift-compiler-to-be-built-without-the-Er.patch, 0005-Make-the-XSD-generator-dynamic.patch, 0006-Remove-t_xsd_generator.h.patch, 0007-Allow-the-Thrift-compiler-to-be-built-without-the-XS.patch, 0008-Make-the-XSD-generator-use-non-hardcoded-namespaces.patch, 0009-Make-the-PHP-generator-dynamic.patch, 0010-Remove-t_php_generator.h.patch, 0011-Allow-the-Thrift-compiler-to-be-built-without-the-PH.patch, 0012-Make-the-PHP-generator-use-non-hardcoded-namespaces.patch, 0013-THRIFT-325.-Remove-a-bunch-of-uses-of-the-old-comman.patch, extra_diffs.patch, thrift-325.patch
>
>
> Generators for PHP, Erlang and XSD still use language-specific CLI options (-php*, -erl, -xsd). They should use the new --gen STR syntax instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.