You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by mc...@apache.org on 2014/11/20 19:52:46 UTC

[1/2] qpid-proton git commit: PROTON-755: Update Ruby smoke tests to use Minitest

Repository: qpid-proton
Updated Branches:
  refs/heads/master b4e06d34a -> b13222b82


PROTON-755: Update Ruby smoke tests to use Minitest

The old test framework module names have changed.


Project: http://git-wip-us.apache.org/repos/asf/qpid-proton/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-proton/commit/1d3a1386
Tree: http://git-wip-us.apache.org/repos/asf/qpid-proton/tree/1d3a1386
Diff: http://git-wip-us.apache.org/repos/asf/qpid-proton/diff/1d3a1386

Branch: refs/heads/master
Commit: 1d3a13863117cfca5aef56244b20773760428796
Parents: b4e06d3
Author: Darryl L. Pierce <mc...@gmail.com>
Authored: Thu Nov 20 13:42:41 2014 -0500
Committer: Darryl L. Pierce <mc...@gmail.com>
Committed: Thu Nov 20 13:45:06 2014 -0500

----------------------------------------------------------------------
 tests/ruby/proton-test             | 2 +-
 tests/ruby/proton_tests/interop.rb | 4 ++--
 tests/ruby/proton_tests/smoke.rb   | 8 ++++----
 3 files changed, 7 insertions(+), 7 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/qpid-proton/blob/1d3a1386/tests/ruby/proton-test
----------------------------------------------------------------------
diff --git a/tests/ruby/proton-test b/tests/ruby/proton-test
index 748e6f0..acb0d43 100755
--- a/tests/ruby/proton-test
+++ b/tests/ruby/proton-test
@@ -1,5 +1,5 @@
 #!/usr/bin/env ruby
 
-require 'test/unit'
+require 'minitest/autorun'
 require 'proton_tests/interop.rb'
 require 'proton_tests/smoke.rb'

http://git-wip-us.apache.org/repos/asf/qpid-proton/blob/1d3a1386/tests/ruby/proton_tests/interop.rb
----------------------------------------------------------------------
diff --git a/tests/ruby/proton_tests/interop.rb b/tests/ruby/proton_tests/interop.rb
index e14cba1..21d92d9 100755
--- a/tests/ruby/proton_tests/interop.rb
+++ b/tests/ruby/proton_tests/interop.rb
@@ -1,6 +1,6 @@
 #!/usr/bin/env ruby
 
-require 'test/unit'
+require 'minitest/autorun'
 require 'qpid_proton'
 
 if ((RUBY_VERSION.split(".").map {|x| x.to_i}  <=> [1, 9]) < 0)
@@ -12,7 +12,7 @@ if ((RUBY_VERSION.split(".").map {|x| x.to_i}  <=> [1, 9]) < 0)
   end
 end
 
-class InteropTest < Test::Unit::TestCase
+class InteropTest < Minitest::Test
   Data = Qpid::Proton::Data
   Message = Qpid::Proton::Message
 

http://git-wip-us.apache.org/repos/asf/qpid-proton/blob/1d3a1386/tests/ruby/proton_tests/smoke.rb
----------------------------------------------------------------------
diff --git a/tests/ruby/proton_tests/smoke.rb b/tests/ruby/proton_tests/smoke.rb
index 6368283..a382a0b 100644
--- a/tests/ruby/proton_tests/smoke.rb
+++ b/tests/ruby/proton_tests/smoke.rb
@@ -1,9 +1,9 @@
 #!/usr/bin/env ruby
 
-require 'test/unit'
+require 'minitest/autorun'
 require 'qpid_proton'
 
-class SmokeTest < Test::Unit::TestCase
+class SmokeTest < Minitest::Test
 
   Messenger = Qpid::Proton::Messenger
   Message = Qpid::Proton::Message
@@ -29,8 +29,8 @@ class SmokeTest < Test::Unit::TestCase
 
     pump()
 
-    assert @client.stopped
-    assert @server.stopped
+    assert @client.stopped?
+    assert @server.stopped?
   end
 
   def testSmoke(count=10)


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org


[2/2] qpid-proton git commit: NO-JIRA: Fix a few Ruby method names to fit naming conventions.

Posted by mc...@apache.org.
NO-JIRA: Fix a few Ruby method names to fit naming conventions.

Messenger::receiving and Messenger::stopped renamed to
Messenger::receiving? and Messenger::stopped?

Also fixed a typo in one rdoc and added rdoc to receiving?


Project: http://git-wip-us.apache.org/repos/asf/qpid-proton/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-proton/commit/b13222b8
Tree: http://git-wip-us.apache.org/repos/asf/qpid-proton/tree/b13222b8
Diff: http://git-wip-us.apache.org/repos/asf/qpid-proton/diff/b13222b8

Branch: refs/heads/master
Commit: b13222b8214f4690c169eefc13354ff5f6479c2e
Parents: 1d3a138
Author: Darryl L. Pierce <mc...@gmail.com>
Authored: Thu Nov 20 13:45:15 2014 -0500
Committer: Darryl L. Pierce <mc...@gmail.com>
Committed: Thu Nov 20 13:46:17 2014 -0500

----------------------------------------------------------------------
 proton-c/bindings/ruby/lib/qpid_proton/messenger.rb | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/qpid-proton/blob/b13222b8/proton-c/bindings/ruby/lib/qpid_proton/messenger.rb
----------------------------------------------------------------------
diff --git a/proton-c/bindings/ruby/lib/qpid_proton/messenger.rb b/proton-c/bindings/ruby/lib/qpid_proton/messenger.rb
index 66a2f93..f17205d 100644
--- a/proton-c/bindings/ruby/lib/qpid_proton/messenger.rb
+++ b/proton-c/bindings/ruby/lib/qpid_proton/messenger.rb
@@ -208,10 +208,10 @@ module Qpid
         Cproton.pn_messenger_stop(@impl)
       end
 
-      # Returns true iff a Messenger is in the stopped state.
+      # Returns true if a Messenger is in the stopped state.
       # This function does not block.
       #
-      def stopped
+      def stopped?
         Cproton.pn_messenger_stopped(@impl)
       end
 
@@ -389,7 +389,8 @@ module Qpid
         Cproton.pn_messenger_recv(@impl, limit)
       end
 
-      def receiving
+      # Returns true if the messenger is currently receiving data.
+      def receiving?
         Cproton.pn_messenger_receiving(@impl)
       end
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org